You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2016/05/10 15:12:40 UTC
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/429
NIFI-1865 Close StreamThrottler when processor stops.
Add close when processor stops.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-1865
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/429.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #429
----
commit ceecc665d3a0f17348436830fd8611e2c4b4596d
Author: Koji Kawamura <ij...@gmail.com>
Date: 2016-05-10T14:45:42Z
NIFI-1865 Close StreamThrottler when processor stops.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218323187
I didn't know that I can push --force a squashed commit, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218321492
@alopresto I heard that single commit would be easier to apply to master and 0.x branch. I squashed the commits and sent a PR #432 . I'll update the same branch and PR when I do rebase, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218318790
@ijokarumawak for future reference, you can push the changes to the same branch and the PR will update automatically. If you decide to rebase, you can do that as well and follow it with `git push --force`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218324462
Yes, some people prefer to `squash` before opening the PR; others open the PR with incremental commits in place to show history/decisions. There are different opinions as to which is easier to review. I believe our [Contributor Guide](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-RebasingandSquashingwhileunderreview) allows for both options. If the PR is not squashed, the committer can always do that (and should) before merging (after review).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218325829
May the --force be with you ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak closed the pull request at:
https://github.com/apache/nifi/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218316718
Thanks for reviewing @mattyb149 , I will fix the texts and resend a PR shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/429#issuecomment-218322096
You're both right :) you can do the squash then a rebase and force push to the same PR. Doesn't matter to me though, I'll grab the latest and review/merge, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1865 Close StreamThrottler when processor ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/429#discussion_r62712326
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPostHTTP.java ---
@@ -407,4 +407,31 @@ public void testSendChunked() throws Exception {
Assert.assertNull(lastPostHeaders.get("Content-Length"));
Assert.assertEquals("chunked",lastPostHeaders.get("Transfer-Encoding"));
}
+
+ @Test
+ public void testSendWithThrottler() throws Exception {
+ setup(null);
+
+ final String suppliedMimeType = "text/plain";
+ runner.setProperty(PostHTTP.URL, server.getUrl());
+ runner.setProperty(PostHTTP.CONTENT_TYPE, suppliedMimeType);
+ runner.setProperty(PostHTTP.CHUNKED_ENCODING, "false");
+ runner.setProperty(PostHTTP.MAX_DATA_RATE, "10kb");
+
+ final Map<String, String> attrs = new HashMap<>();
+ attrs.put(CoreAttributes.MIME_TYPE.key(), "text/plain");
+
+ runner.enqueue(StringUtils.repeat("This is the song that never ends. It goes on and on my friend.", 100).getBytes(), attrs);
--- End diff --
These song lyrics are copyrighted :-/ Need to replace with some other generic sample text
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---