You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/07/07 20:28:30 UTC
Review Request 23315: s/Unsecure/Insecure/
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Unsecure is not a word.
Diffs
-----
src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
Diff: https://reviews.apache.org/r/23315/diff/
Testing
-------
./gradlew test
Thanks,
Brian Wickman
Re: Review Request 23315: s/Unsecure/Insecure/
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/#review49044
-----------------------------------------------------------
Update or discard?
- Bill Farner
On July 7, 2014, 6:28 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23315/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 6:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unsecure is not a word.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
>
> Diff: https://reviews.apache.org/r/23315/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23315: s/Unsecure/Insecure/
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/#review47406
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On July 7, 2014, 11:28 a.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23315/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 11:28 a.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unsecure is not a word.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
>
> Diff: https://reviews.apache.org/r/23315/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23315: s/Unsecure/Insecure/
Posted by Brian Wickman <wi...@apache.org>.
> On July 8, 2014, 3:06 p.m., Bill Farner wrote:
> > This naming is deliberate, and AFAIK the term is used correctly.
> > http://english.stackexchange.com/questions/19653/insecure-or-unsecure-when-dealing-with-security
> >
> > Perhaps the appropriate change is 'UnsecuredAuthModule'
The More You Know™
happy to change to Unsecured.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/#review47447
-----------------------------------------------------------
On July 7, 2014, 6:28 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23315/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 6:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unsecure is not a word.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
>
> Diff: https://reviews.apache.org/r/23315/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23315: s/Unsecure/Insecure/
Posted by Bill Farner <wf...@apache.org>.
> On July 8, 2014, 3:06 p.m., Bill Farner wrote:
> > This naming is deliberate, and AFAIK the term is used correctly.
> > http://english.stackexchange.com/questions/19653/insecure-or-unsecure-when-dealing-with-security
> >
> > Perhaps the appropriate change is 'UnsecuredAuthModule'
>
> Brian Wickman wrote:
> The More You Know™
>
> happy to change to Unsecured.
sgtm!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/#review47447
-----------------------------------------------------------
On July 7, 2014, 6:28 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23315/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 6:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unsecure is not a word.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
>
> Diff: https://reviews.apache.org/r/23315/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23315: s/Unsecure/Insecure/
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23315/#review47447
-----------------------------------------------------------
This naming is deliberate, and AFAIK the term is used correctly.
http://english.stackexchange.com/questions/19653/insecure-or-unsecure-when-dealing-with-security
Perhaps the appropriate change is 'UnsecuredAuthModule'
- Bill Farner
On July 7, 2014, 6:28 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23315/
> -----------------------------------------------------------
>
> (Updated July 7, 2014, 6:28 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Unsecure is not a word.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 912e465793b42c81040a8cfe507c2e341932c205
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 6d18695cf6cfb6ee7b33d51c921bf40e5e98291d
>
> Diff: https://reviews.apache.org/r/23315/diff/
>
>
> Testing
> -------
>
> ./gradlew test
>
>
> Thanks,
>
> Brian Wickman
>
>