You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/13 22:37:44 UTC
[GitHub] [solr] madrob opened a new pull request #75: SOLR-15334 Throw exception on failure in PKIAuthPlugin
madrob opened a new pull request #75:
URL: https://github.com/apache/solr/pull/75
https://issues.apache.org/jira/browse/SOLR-15334
I made some conservative changes here, but the main effort was replacing all of the pass throughs with throwing Exceptions. We could probably remove more code if this is the right way to go instead of hiding behind `assert` statements.
Am I misunderstanding something about the intent here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob merged pull request #75: SOLR-15334 Throw exception on failure in PKIAuthPlugin
Posted by GitBox <gi...@apache.org>.
madrob merged pull request #75:
URL: https://github.com/apache/solr/pull/75
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] anshumg commented on a change in pull request #75: SOLR-15334 Throw exception on failure in PKIAuthPlugin
Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #75:
URL: https://github.com/apache/solr/pull/75#discussion_r612830144
##########
File path: solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
##########
@@ -84,46 +84,40 @@ public void init(Map<String, Object> pluginConfig) {
@SuppressForbidden(reason = "Needs currentTimeMillis to compare against time in header")
@Override
public boolean doAuthenticate(HttpServletRequest request, HttpServletResponse response, FilterChain filterChain) throws Exception {
+ // Getting the received time must be the first thing we do, processing the request can take time
+ long receivedTime = System.currentTimeMillis();
String requestURI = request.getRequestURI();
if (requestURI.endsWith(PublicKeyHandler.PATH)) {
+ assert false : "Should already be handled by SolrDispatchFilter.authenticateRequest";
Review comment:
do we need this here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org