You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/06/30 19:22:35 UTC
[GitHub] [hbase-operator-tools] z-york opened a new pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
z-york opened a new pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] taklwu commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
taklwu commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871729919
I tried to build with `-Dhbase.version=2.3.5` and it worked.
IMO if we would like to move with `hbase.version`, should we do it with the stable pointer as of today it's [2.3.5](https://hbase.apache.org/downloads.html)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661810398
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
Good call out, fixed in latest update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661812267
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Looks like it's all `CheckForNull` annotations to make spotbugs / findbugs do a better job of warning about usage.
https://spotbugs.readthedocs.io/en/stable/annotations.html#edu-umd-cs-findbugs-annotations-checkfornull
Any particular reason you want to get this out of here @saintstack ? we have the stephenc clean room findbugs dependency in lots of places across the project already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] saintstack commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
saintstack commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871741704
Thanks @z-york for explaining why the changes needed.
Suggest that updating the hbase dependency is another issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] busbey commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661812267
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Looks like it's all `CheckForNull` annotations to make spotbugs / findbugs do a better job of warning about usage.
https://spotbugs.readthedocs.io/en/stable/annotations.html#edu-umd-cs-findbugs-annotations-checkfornull
Any particular reason you want to get this out of here @saintstack ? we have this one in lots of places across the project already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871736324
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 0m 29s | master passed |
| +1 :green_heart: | compile | 0m 20s | master passed |
| +1 :green_heart: | checkstyle | 0m 11s | master passed |
| +1 :green_heart: | javadoc | 0m 14s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 28s | the patch passed |
| +1 :green_heart: | compile | 0m 20s | the patch passed |
| +1 :green_heart: | javac | 0m 20s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 8s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 10s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 13s | hbase-hbck2 in the patch passed. |
| -1 :x: | unit | 7m 9s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 16m 17s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hbase.TestRegionsMerger |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/2/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/90 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 00697b26d0a5 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 2317f13 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/2/artifact/yetus-precommit-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/2/testReport/ |
| Max. process+thread count | 1218 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/2/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-875043487
Sorry, I submitted this as I was on my way out the door on vacation. I'll commit and open another task for upgrading the version. As for actually running findbugs, if we aren't already doing that, I'll leave that to someone who understands it a bit better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871722145
Added build output from building with 2.4.4 to the JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661803931
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
I'm not very familiar with the findbugs annotations. I guess we could change to using Preconditions or something, but that will be a runtime check. If findbugs is doing something at compile time with those annotations, it might not be a comparable switch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661824460
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
@busbey just the usual... lets minimize dependencies if we can. Was wondering if the dependency was just because of some silly, minor usage that we could as well do w/o.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] virajjasani commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-874262467
We are good to ship this I think. @z-york are you also planning to bump HBase version to 2.4.x on follow up Jira?
Thanks for catching these issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] virajjasani commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-874262467
We are good to ship this I think. @z-york are you also planning to bump HBase version to 2.4.x on follow up Jira?
Thanks for catching these issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661825885
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
I may be out of the picture, but in this tool, did we enable any findbugs plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871724033
Also, I'm not sure what our procedure is for upgrading the HBase version in operator tools. I left it at the lower version since the code change works for both versions, but I can upgrade too if it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871719190
@saintstack
The executor changes are caused by https://github.com/apache/hbase/commit/8ccf643fdc96a5f70106a50fb08f0e37dcf80ec5 (basically the method was removed in favor of using the guava method).
https://github.com/apache/hbase-operator-tools/commit/b461d58833cee465b18e46780ebb85c7b159df44 Adds the CheckForNull. I also see that it's referenced in core HBase (for example in FSUtils.java).
The reason this fails for 2.4.4 is due to this change: https://issues.apache.org/jira/browse/HBASE-23077 that adds the dependency as compile scope where needed within HBase core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-875062567
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 41s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 39s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 0m 33s | master passed |
| +1 :green_heart: | compile | 0m 19s | master passed |
| +1 :green_heart: | checkstyle | 0m 10s | master passed |
| +1 :green_heart: | javadoc | 0m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 26s | the patch passed |
| +1 :green_heart: | compile | 0m 20s | the patch passed |
| +1 :green_heart: | javac | 0m 20s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 8s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 10s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | unit | 7m 10s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 16m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/3/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/90 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 4871266cd9a6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 2317f13 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/3/testReport/ |
| Max. process+thread count | 1221 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/3/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661825885
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
I may be out of the picture, but in this tool, did we enable any findbugs plugin ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661827001
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Stephen beat me to it :) I'm not sure if it's setup correctly for hbase-operator-tools (the test report lists spotbugs as 'spotbugs executables are not available').
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york merged pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york merged pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] Apache-HBase commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871676451
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 5s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | spotbugs | 0m 0s | spotbugs executables are not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 0m 29s | master passed |
| +1 :green_heart: | compile | 0m 20s | master passed |
| +1 :green_heart: | checkstyle | 0m 10s | master passed |
| +1 :green_heart: | javadoc | 0m 12s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 4s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 19s | the patch passed |
| +1 :green_heart: | javac | 0m 19s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 8s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 0m 11s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 5m 17s | hbase-hbck2 in the patch passed. |
| +1 :green_heart: | unit | 7m 15s | root in the patch passed. |
| +1 :green_heart: | asflicense | 0m 9s | The patch does not generate ASF License warnings. |
| | | 16m 52s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/1/artifact/yetus-precommit-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase-operator-tools/pull/90 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux 8f4f1c022aec 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux |
| Build tool | maven |
| git revision | master / 2317f13 |
| Default Java | Oracle Corporation-1.8.0_282-b08 |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/1/testReport/ |
| Max. process+thread count | 1186 (vs. ulimit of 5000) |
| modules | C: hbase-hbck2 . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-Operator-Tools-PreCommit/job/PR-90/1/console |
| versions | git=2.20.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661808404
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
+ <scope>compile</scope>
+ </dependency>
Review comment:
[nit] indentation is off 2 spaces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] taklwu commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
taklwu commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661825885
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
I may be out of the picture, but in this tool, did we enable any findbugs plugin?
if we're issuing findbugs warnings, we're doing it somewhat right with `@CheckForNull` but this annotation is for JSR-305 and it's a bit old?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-871669261
I guess the build wouldn't catch this, but it will ensure no regressions with older releases. This change is compatible with the older versions and 2.4.4.
Build with 2.4.4:
hbase-operator-tools % mvn clean install -DskipTests -Dhbase.version=2.4.4
`[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Operator Tools 1.2.0-SNAPSHOT:
[INFO]
[INFO] Apache HBase Operator Tools ........................ SUCCESS [ 10.389 s]
[INFO] Apache HBase - Table Reporter ...................... SUCCESS [ 41.494 s]
[INFO] Apache HBase - HBCK2 ............................... SUCCESS [ 52.119 s]
[INFO] Apache HBase - HBase Tools ......................... SUCCESS [ 12.464 s]
[INFO] Apache HBase Operator Tools - Assembly ............. SUCCESS [ 0.423 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:58 min
[INFO] Finished at: 2021-06-30T12:19:53-07:00
[INFO] ------------------------------------------------------------------------`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] saintstack commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661788980
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Do we need this thing? Can we purge the annotation referenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] z-york commented on a change in pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4
Posted by GitBox <gi...@apache.org>.
z-york commented on a change in pull request #90:
URL: https://github.com/apache/hbase-operator-tools/pull/90#discussion_r661827001
##########
File path: hbase-hbck2/pom.xml
##########
@@ -235,6 +235,12 @@
<version>2.1.0</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.stephenc.findbugs</groupId>
+ <artifactId>findbugs-annotations</artifactId>
+ <version>${findbugs-annotations.version}</version>
Review comment:
Btw, are we actually running findbugs? I'm not sure if it's setup correctly for hbase-operator-tools (the test report lists spotbugs as 'spotbugs executables are not available').
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org