You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tanmayrauth (via GitHub)" <gi...@apache.org> on 2026/04/16 22:20:34 UTC
[I] Add ListableIO interface to replace reflect-based directory walking [iceberg-go]
tanmayrauth opened a new issue, #913:
URL: https://github.com/apache/iceberg-go/issues/913
### Feature Request / Improvement
Parent issue: #831
`table/orphan_cleanup.go:313` uses `reflect.ValueOf(fsys).Elem().FieldByName("Bucket")` to grab the underlying `fs.FS` from blob storage IO implementations for directory walking. This is fragile and will break any custom IO implementation that doesn't have a `Bucket` field with the expected type.
A proper `ListableIO` interface should be added to `io/io.go` with a `WalkDir(root string, fn fs.WalkDirFunc) error` method, following the existing optional interface pattern (`ReadFileIO`, `WriteFileIO`). Each blob storage IO implementation would implement `WalkDir` using its native listing API.
The `walkDirectory` function and `getBucketName` reflect hack in orphan cleanup can then be replaced with a simple type assertion against `ListableIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Add ListableIO interface to replace reflect-based directory walking [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on issue #913:
URL: https://github.com/apache/iceberg-go/issues/913#issuecomment-4263796982
I will work on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Add ListableIO interface to replace reflect-based directory walking [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #913: Add ListableIO interface to replace reflect-based directory walking
URL: https://github.com/apache/iceberg-go/issues/913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org