You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/11/09 21:12:07 UTC
[GitHub] [jena] afs opened a new pull request, #1613: GH-1612: TDB2 opt file: allow in container directory
afs opened a new pull request, #1613:
URL: https://github.com/apache/jena/pull/1613
GitHub issue resolved #1612
Pull request Description:
Allow "opt" files in the container directory.
----
- [x] Tests are included.
- [x] Commits have been squashed to remove intermediate development commit messages.
- [x] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1613: GH-1612: TDB2 opt file: allow in container directory
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1613:
URL: https://github.com/apache/jena/pull/1613#discussion_r1018974497
##########
jena-tdb1/src/main/java/org/apache/jena/tdb/sys/Names.java:
##########
@@ -21,64 +21,64 @@
/** Names of things in TDB */
public class Names
{
- public static final String primaryIndexTriples = "SPO" ;
+ public static final String primaryIndexTriples = "SPO" ;
public static final String[] tripleIndexes = { primaryIndexTriples, "POS", "OSP" } ;
- public static final String primaryIndexQuads = "GSPO" ;
+ public static final String primaryIndexQuads = "GSPO" ;
public static final String[] quadIndexes = { primaryIndexQuads, "GPOS", "GOSP", "POSG", "OSPG", "SPOG"} ;
-
+
public static final String primaryIndexPrefix = "GPU" ;
Review Comment:
No :-)
GPU = Graph-Prefix-URI.
It is the prefix storage table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1613: GH-1612: TDB2 opt file: allow in container directory
Posted by GitBox <gi...@apache.org>.
afs merged PR #1613:
URL: https://github.com/apache/jena/pull/1613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a diff in pull request #1613: GH-1612: TDB2 opt file: allow in container directory
Posted by GitBox <gi...@apache.org>.
rvesse commented on code in PR #1613:
URL: https://github.com/apache/jena/pull/1613#discussion_r1018950064
##########
jena-tdb1/src/main/java/org/apache/jena/tdb/sys/Names.java:
##########
@@ -21,64 +21,64 @@
/** Names of things in TDB */
public class Names
{
- public static final String primaryIndexTriples = "SPO" ;
+ public static final String primaryIndexTriples = "SPO" ;
public static final String[] tripleIndexes = { primaryIndexTriples, "POS", "OSP" } ;
- public static final String primaryIndexQuads = "GSPO" ;
+ public static final String primaryIndexQuads = "GSPO" ;
public static final String[] quadIndexes = { primaryIndexQuads, "GPOS", "GOSP", "POSG", "OSPG", "SPOG"} ;
-
+
public static final String primaryIndexPrefix = "GPU" ;
Review Comment:
Not part of this PR but `GPU` - is this a typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org