Re: svn commit: r105955 - in spamassassin/trunk: . lib/Mail

[Justin Mason <jm...@jmason.org>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


reminder: do we have a consensus what to do about this?  can we reinstate
the functions in the meantime?

- --j.

quinlan@apache.org writes:
> Author: quinlan
> Date: Sat Nov 20 00:17:49 2004
> New Revision: 105955
> 
> Modified:
>    spamassassin/trunk/lib/Mail/SpamAssassin.pm
>    spamassassin/trunk/spamassassin.raw
> Log:
> bug 3856: remove debug_diagnostics() from Mail::SpamAssassin
> 
> Modified: spamassassin/trunk/lib/Mail/SpamAssassin.pm
> ==============================================================================
> --- spamassassin/trunk/lib/Mail/SpamAssassin.pm	(original)
> +++ spamassassin/trunk/lib/Mail/SpamAssassin.pm	Sat Nov 20 00:17:49 2004
> @@ -1159,35 +1159,6 @@
>  
>  ###########################################################################
>  
> -=item $f->debug_diagnostics ()
> -
> -Output some diagnostic information, useful for debugging SpamAssassin
> -problems.
> -
> -=cut
> -
> -sub debug_diagnostics {
> -  my ($self) = @_;
> -
> -  foreach my $module (sort qw(
> -        Net::DNS Razor2::Client::Agent MIME::Base64
> -        IO::Socket::UNIX DB_File Digest::SHA1
> -        DBI URI Net::LDAP Storable
> -        ))
> -  {
> -    my $modver;
> -    if (eval ' require '.$module.'; $modver = $'.$module.'::VERSION; 1;')
> -    {
> -      $modver ||= '(undef)';
> -      dbg("diag: module installed: $module, version $modver");
> -    } else {
> -      dbg("diag: module not installed: $module ('require' failed)");
> -    }
> -  }
> -}
> -
> -###########################################################################
> -
>  =item $failed = $f->lint_rules ()
>  
>  Syntax-check the current set of rules.  Returns the number of 
> 
> Modified: spamassassin/trunk/spamassassin.raw
> ==============================================================================
> --- spamassassin/trunk/spamassassin.raw	(original)
> +++ spamassassin/trunk/spamassassin.raw	Sat Nov 20 00:17:49 2004
> @@ -240,7 +240,6 @@
>  );
>  
>  if ( $opt{'lint'} ) {
> -  $spamtest->debug_diagnostics();
>    my $res = $spamtest->lint_rules();
>    warn "lint: $res issues detected.  please rerun with debug enabled for more information.\n" if ($res);
>    exit $res ? 1: 0;
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
Comment: Exmh CVS

iD8DBQFBo/72MJF5cimLx9ARAnxLAJ9dZWJ56pvO49Pf6JlUjzltegzmZwCfcyDk
ZArJ2xKE6qz2EDaKqjDenG4=
=CNr3
-----END PGP SIGNATURE-----

Re: svn commit: r105955 - in spamassassin/trunk: . lib/Mail

[Daniel Quinlan <qu...@pathname.com>]

jm@jmason.org (Justin Mason) writes:

> reminder: do we have a consensus what to do about this?  can we reinstate
> the functions in the meantime?

*sigh*

Given that you want to leave them in SpamAssassin.pm rather than
preserve the functionality, I don't think there's much of a choice.

I may still nuke the perl module version dumping, though.  There's got
to be a better way to do that.

-- 
Daniel Quinlan
http://www.pathname.com/~quinlan/