You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Karl Wettin (JIRA)" <ji...@apache.org> on 2008/08/12 16:06:44 UTC
[jira] Commented: (MAHOUT-72) Separate out Examples from Core
[ https://issues.apache.org/jira/browse/MAHOUT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621825#action_12621825 ]
Karl Wettin commented on MAHOUT-72:
-----------------------------------
Actually, the patch looks a bit funky, I used svn mv core/src/main/examples examples/src/main/java, but it doesn't seem to have moved them at all in the patch, just deleted them?
> Separate out Examples from Core
> -------------------------------
>
> Key: MAHOUT-72
> URL: https://issues.apache.org/jira/browse/MAHOUT-72
> Project: Mahout
> Issue Type: Improvement
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-72.txt
>
>
> Let's make the Examples standalone as a separate module w/ a separate build, as they aren't "core".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Sean Owen <sr...@gmail.com>.
svn delete and svn add is fine by me, if it comes down to it. Yeah you
lose the continuous change history, that's about it.
I consider myself an Ant ace, happy to help if there are any issues. I
don't think a top-level build file needs to do much more than
<antcall> to targets in the subdirectory scripts.
On Wed, Aug 13, 2008 at 9:21 AM, Karl Wettin <ka...@gmail.com> wrote:
>
> 12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>>
>> Actually, the patch looks a bit funky, I used svn mv
>> core/src/main/examples examples/src/main/java, but it doesn't seem to have
>> moved them at all in the patch, just deleted them?
>
> Does anyone know what I did wrong? Do I perhaps need to do something more
> than svn mv?
>
> I'll start looking at a top level Ant build too, but I'm rather lame when it
> comes to Ant. I'll just look at the Lucene build and see if I can use that.
>
>
> karl
>
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Thilo Goetz <tw...@gmx.de>.
All I know is that file moves/renames don't work well in
patches. It's better to do them directly in svn, or have
somebody with sufficient karma do it. That's been my
experience, anyway.
--Thilo
Karl Wettin wrote:
>
> 12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>>
>> Actually, the patch looks a bit funky, I used svn mv
>> core/src/main/examples examples/src/main/java, but it doesn't seem to
>> have moved them at all in the patch, just deleted them?
>
> Does anyone know what I did wrong? Do I perhaps need to do something
> more than svn mv?
>
> I'll start looking at a top level Ant build too, but I'm rather lame
> when it comes to Ant. I'll just look at the Lucene build and see if I
> can use that.
>
>
> karl
Re: [jira] Commented: (MAHOUT-72) Separate out Examples from Core
Posted by Karl Wettin <ka...@gmail.com>.
12 aug 2008 kl. 16.06 skrev Karl Wettin (JIRA):
>
> Actually, the patch looks a bit funky, I used svn mv core/src/main/
> examples examples/src/main/java, but it doesn't seem to have moved
> them at all in the patch, just deleted them?
Does anyone know what I did wrong? Do I perhaps need to do something
more than svn mv?
I'll start looking at a top level Ant build too, but I'm rather lame
when it comes to Ant. I'll just look at the Lucene build and see if I
can use that.
karl