[GitHub] [spark] HeartSaVioR commented on a change in pull request #26778: [SPARK-30148][SQL] Optimize writing plans if there is an analysis exception

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #26778: [SPARK-30148][SQL] Optimize writing plans if there is an analysis exception
URL: https://github.com/apache/spark/pull/26778#discussion_r354794198
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
 ##########
 @@ -144,13 +145,21 @@ class QueryExecution(
       )
       append("\n")
     } catch {
-      case _: AnalysisException =>
+      case e: AnalysisException => analysisException = e.toString
+    }
+    if (analysisException.size > 0) {
+      QueryPlan.append(analyzed, append, verbose, addSuffix, maxFields)
 
 Review comment:
   Statements for if and else seems to be swapped.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org