You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by mibo <gi...@git.apache.org> on 2018/04/02 05:36:04 UTC

[GitHub] qpid-jms issue #17: QPIDJMS-374: Use getRawQuery to avoid double encoding

Github user mibo commented on the issue:

    https://github.com/apache/qpid-jms/pull/17
  
    I agree that using `PropertyUtil.parseQuery(remoteURI)` would be better (which then does the `PropertyUtil.parseQuery(uri.getRawQuery())` call after a [null check](https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/util/PropertyUtil.java#L189)).
    I will change it and add the currently missing (JUnit) tests.
    But I think we can agree that using `PropertyUtil.parseQuery(remoteURI.getQuery())` is a bug.
    
    Btw. I oriented the fix by the [TransportFactory](https://github.com/apache/qpid-jms/blob/70fe1b882e1381b1016a10b0707f6e112d4e0598/qpid-jms-client/src/main/java/org/apache/qpid/jms/transports/TransportFactory.java#L51).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org