You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/04 15:31:59 UTC
[GitHub] [pulsar] KannarFr opened a new pull request #6870: fix
KannarFr opened a new pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870
Use originalAuthMethod on originalAuthProvider check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] KannarFr commented on pull request #6870: use originalAuthMethod on originalAuthChecker
Posted by GitBox <gi...@apache.org>.
KannarFr commented on pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870#issuecomment-624708931
Nvm, missed: `forwardAuthorizationCredentials=true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] KannarFr commented on pull request #6870: use originalAuthMethod on originalAuthChecker
Posted by GitBox <gi...@apache.org>.
KannarFr commented on pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870#issuecomment-624368395
@sijie can you review it? Do it cover all cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #6870: use originalAuthMethod on originalAuthChecker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870#issuecomment-624407862
> @sijie can you review it? Do it cover all cases?
This is the only place that I can see.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #6870: use originalAuthMethod on originalAuthChecker
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870#issuecomment-624406102
@KannarFr Thanks for the fix. Seems there is no test cover this case, Would you please also help provide a test for this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] KannarFr commented on pull request #6870: use originalAuthMethod on originalAuthChecker
Posted by GitBox <gi...@apache.org>.
KannarFr commented on pull request #6870:
URL: https://github.com/apache/pulsar/pull/6870#issuecomment-624697265
@jiazhai @sijie We have an interesting issue, the original auth method & auth data are empty. Only the original principal is filled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org