You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/10 14:39:35 UTC
[GitHub] [superset] maloun96 opened a new pull request #13057: feat: Add sort by metric for pivot-table
maloun96 opened a new pull request #13057:
URL: https://github.com/apache/superset/pull/13057
### SUMMARY
Add sort by metric for pivot-table
Associated with:
### AFTER
### TEST PLAN
Select pivot table
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (078bf97) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.67%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.73% +8.67%
==========================================
Files 489 980 +491
Lines 17314 46218 +28904
Branches 4482 4494 +12
==========================================
+ Hits 9187 28534 +19347
- Misses 8127 17684 +9557
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.42% <28.57%> (+0.36%)` | :arrow_up: |
| python | `66.72% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...078bf97](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (078bf97) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.88%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.94% +8.88%
==========================================
Files 489 980 +491
Lines 17314 46218 +28904
Branches 4482 4494 +12
==========================================
+ Hits 9187 28632 +19445
- Misses 8127 17586 +9459
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.42% <28.57%> (+0.36%)` | :arrow_up: |
| python | `67.06% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...078bf97](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (078bf97) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.90%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.97% +8.90%
==========================================
Files 489 980 +491
Lines 17314 46246 +28932
Branches 4482 4494 +12
==========================================
+ Hits 9187 28659 +19472
- Misses 8127 17587 +9460
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.42% <28.57%> (+0.36%)` | :arrow_up: |
| python | `67.09% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...078bf97](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (9321181) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.78%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.84% +8.78%
==========================================
Files 489 979 +490
Lines 17314 46229 +28915
Branches 4482 4486 +4
==========================================
+ Hits 9187 28589 +19402
- Misses 8127 17640 +9513
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.02% <28.57%> (-0.04%)` | :arrow_down: |
| python | `67.12% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [512 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574203535
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
+ if sort_by:
+ sort_by_label = utils.get_metric_name(sort_by)
+ if sort_by_label not in d["metrics"]:
+ d["metrics"].append(sort_by)
+ d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))]
Review comment:
This is incorrect. The second parameter in the `orderby` tuple is "is_ascending", which is the opposite meaning of `order_desc`. However, we also want the default to be order in descending in case `order_desc` is not set because it's the most sensible default when a sort by metric is specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (9321181) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.91%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.98% +8.91%
==========================================
Files 489 979 +490
Lines 17314 46229 +28915
Branches 4482 4486 +4
==========================================
+ Hits 9187 28653 +19466
- Misses 8127 17576 +9449
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.39% <28.57%> (+0.33%)` | :arrow_up: |
| python | `67.12% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [507 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (0d3420e) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `14.22%`.
> The diff coverage is `64.28%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 67.28% +14.22%
===========================================
Files 489 489
Lines 17314 28760 +11446
Branches 4482 0 -4482
===========================================
+ Hits 9187 19352 +10165
- Misses 8127 9408 +1281
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `67.28% <64.28%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.84% <0.00%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...board/components/gridComponents/new/NewDivider.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdEaXZpZGVyLmpzeA==) | | |
| [...-frontend/src/dashboard/actions/dashboardLayout.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZExheW91dC5qcw==) | | |
| [...perset-frontend/src/dashboard/util/isValidChild.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzVmFsaWRDaGlsZC50cw==) | | |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | | |
| ... and [965 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...0d3420e](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (0d3420e) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `14.19%`.
> The diff coverage is `64.28%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 67.25% +14.19%
===========================================
Files 489 489
Lines 17314 28760 +11446
Branches 4482 0 -4482
===========================================
+ Hits 9187 19342 +10155
- Misses 8127 9418 +1291
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `67.25% <64.28%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.84% <0.00%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...nd/src/messageToasts/components/ToastPresenter.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29tcG9uZW50cy9Ub2FzdFByZXNlbnRlci50c3g=) | | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | | |
| [...perset-frontend/src/utils/getControlsForVizType.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENvbnRyb2xzRm9yVml6VHlwZS5qcw==) | | |
| ... and [965 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...0d3420e](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574437553
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
I was super confused by the name yesterday, and agree we need to get rid of it. I'm ok both ways, but I think it might be simpler to do a bulk rename later to avoid partially migrated names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (61349b9) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.79%`.
> The diff coverage is `30.50%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.85% +8.79%
==========================================
Files 489 981 +492
Lines 17314 46368 +29054
Branches 4482 4505 +23
==========================================
+ Hits 9187 28680 +19493
- Misses 8127 17688 +9561
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.37% <28.57%> (+0.31%)` | :arrow_up: |
| python | `66.92% <30.63%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.94% <9.33%> (ø)` | |
| ... and [531 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...61349b9](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-779328715
@villebro those changes are relatively low risk, instead of pulling each PR, I will take a look once they are on master all at once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r573827235
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
I am curious, why use `timeseries_limit_metric` control in a not time-series chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (291e576) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.74%`.
> The diff coverage is `41.89%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.80% +13.74%
===========================================
Files 489 490 +1
Lines 17314 28888 +11574
Branches 4482 0 -4482
===========================================
+ Hits 9187 19299 +10112
- Misses 8127 9589 +1462
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.80% <41.89%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.98% <10.52%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | | |
| [...src/SqlLab/components/ExploreCtasResultsButton.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVDdGFzUmVzdWx0c0J1dHRvbi5qc3g=) | | |
| [superset-frontend/src/explore/constants.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLmpz) | | |
| [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (61349b9) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.86%`.
> The diff coverage is `30.63%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.92% +13.86%
===========================================
Files 489 491 +2
Lines 17314 29009 +11695
Branches 4482 0 -4482
===========================================
+ Hits 9187 19414 +10227
- Misses 8127 9595 +1468
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.92% <30.63%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.94% <9.33%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | | |
| [...set-frontend/src/dashboard/util/getDashboardUrl.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZFVybC5qcw==) | | |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | | |
| [superset-frontend/src/components/ChartIcon.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnRJY29uLnRzeA==) | | |
| ... and [967 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...61349b9](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574169126
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
I think this is just from legacy form_data field names. We'd need a db migration if we want to rename it.
Superset has a timeseries-first UI. Each pivot group can be considered a series since the base query has the ability to aggregate by time + pivot column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (9321181) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.65%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.71% +13.65%
===========================================
Files 489 490 +1
Lines 17314 28882 +11568
Branches 4482 0 -4482
===========================================
+ Hits 9187 19269 +10082
- Misses 8127 9613 +1486
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.71% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (078bf97) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `8.93%`.
> The diff coverage is `34.65%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
==========================================
+ Coverage 53.06% 61.99% +8.93%
==========================================
Files 489 980 +491
Lines 17314 46246 +28932
Branches 4482 4494 +12
==========================================
+ Hits 9187 28670 +19483
- Misses 8127 17576 +9449
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.42% <28.57%> (+0.36%)` | :arrow_up: |
| python | `67.12% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rontend/src/components/ListView/CardSortSelect.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvQ2FyZFNvcnRTZWxlY3QudHN4) | `78.94% <ø> (ø)` | |
| [...ontend/src/components/ListViewCard/ImageLoader.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0ltYWdlTG9hZGVyLnRzeA==) | `75.00% <0.00%> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `79.81% <ø> (+5.50%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `76.00% <ø> (ø)` | |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `68.96% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `32.05% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/welcome/Welcome.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9XZWxjb21lLnRzeA==) | `2.94% <0.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| ... and [519 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...078bf97](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maloun96 edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
maloun96 edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-778088662
in this commit https://github.com/apache/superset/pull/13057/commits/61349b92e8a2946d7670aabeca22d8d68ea6d965
I added an if statement, if the checkbox is not selected then it will not sort by default "ASC
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (5b7e9fb) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.72%`.
> The diff coverage is `38.09%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.78% +13.72%
===========================================
Files 489 490 +1
Lines 17314 28898 +11584
Branches 4482 0 -4482
===========================================
+ Hits 9187 19300 +10113
- Misses 8127 9598 +1471
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.78% <38.09%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.71% <10.41%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [superset-frontend/src/modules/dates.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvZGF0ZXMuanM=) | | |
| [...rontend/src/dashboard/components/DashboardGrid.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZEdyaWQuanN4) | | |
| [...essageToasts/utils/getToastsFromPyFlashMessages.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvdXRpbHMvZ2V0VG9hc3RzRnJvbVB5Rmxhc2hNZXNzYWdlcy5qcw==) | | |
| [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (61349b9) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.79%`.
> The diff coverage is `30.63%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.85% +13.79%
===========================================
Files 489 491 +2
Lines 17314 28981 +11667
Branches 4482 0 -4482
===========================================
+ Hits 9187 19375 +10188
- Misses 8127 9606 +1479
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.85% <30.63%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.94% <9.33%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | | |
| [superset-frontend/src/common/hooks/usePrevious.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VQcmV2aW91cy50cw==) | | |
| [...omponents/nativeFilters/FilterConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwvdXRpbHMudHM=) | | |
| [superset-frontend/src/common/components/Fade.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0ZhZGUudHN4) | | |
| ... and [967 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...61349b9](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (6dff6d2) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.74%`.
> The diff coverage is `56.25%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.80% +13.74%
===========================================
Files 489 490 +1
Lines 17314 28836 +11522
Branches 4482 0 -4482
===========================================
+ Hits 9187 19263 +10076
- Misses 8127 9573 +1446
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.80% <56.25%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.63% <0.00%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/data/hooks.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9ob29rcy50cw==) | | |
| [superset-frontend/src/components/EditableTitle.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS50c3g=) | | |
| [superset-frontend/src/setup/setupFormatters.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy50cw==) | | |
| [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...6dff6d2](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (9321181) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `14.06%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 67.12% +14.06%
===========================================
Files 489 490 +1
Lines 17314 28910 +11596
Branches 4482 0 -4482
===========================================
+ Hits 9187 19405 +10218
- Misses 8127 9505 +1378
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `67.12% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | | |
| [...set-frontend/src/common/components/InfoTooltip.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL0luZm9Ub29sdGlwLnRzeA==) | | |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | | |
| [...nd/src/dashboard/components/gridComponents/Row.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL1Jvdy5qc3g=) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...9321181](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] maloun96 commented on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
maloun96 commented on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-778088662
in this commit https://github.com/apache/superset/pull/13057/commits/61349b92e8a2946d7670aabeca22d8d68ea6d965
I added a if statement if is not selected that it will not sort "asc"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574174308
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
Wait a minute, since this is a new field for pivot table and https://github.com/apache-superset/superset-ui/pull/952 hasn't been merged, maybe we CAN rename it to something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574193724
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
+ if sort_by:
+ sort_by_label = utils.get_metric_name(sort_by)
+ if sort_by_label not in d["metrics"]:
+ d["metrics"].append(sort_by)
+ d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))]
Review comment:
it is may be more readable
```suggestion
d["orderby"] = [(sort_by, bool(self.form_data.get("order_desc"))]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (078bf97) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.66%`.
> The diff coverage is `35.10%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.72% +13.66%
===========================================
Files 489 490 +1
Lines 17314 28888 +11574
Branches 4482 0 -4482
===========================================
+ Hits 9187 19275 +10088
- Misses 8127 9613 +1486
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.72% <35.10%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `57.43% <10.34%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...Control/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyRWRpdFBvcG92ZXJTaW1wbGVUYWJDb250ZW50LmpzeA==) | | |
| [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | | |
| [...hboard/util/getChartAndLabelComponentIdFromPath.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldENoYXJ0QW5kTGFiZWxDb21wb25lbnRJZEZyb21QYXRoLmpz) | | |
| [...t-frontend/src/dashboard/reducers/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9uYXRpdmVGaWx0ZXJzLnRz) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...078bf97](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574203535
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
+ if sort_by:
+ sort_by_label = utils.get_metric_name(sort_by)
+ if sort_by_label not in d["metrics"]:
+ d["metrics"].append(sort_by)
+ d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))]
Review comment:
This is incorrect. The second parameter in the `orderby` tuple is "is_ascending", which is the opposite meaning of `order_desc`. However, we also want the default to be order in descending in case `order_desc` is not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574203535
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
+ if sort_by:
+ sort_by_label = utils.get_metric_name(sort_by)
+ if sort_by_label not in d["metrics"]:
+ d["metrics"].append(sort_by)
+ d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))]
Review comment:
This is incorrect. The second parameter is the `orderby` tuple is "is_ascending", which is the opposite meaning of `order_desc`. However, we also want the default to be order in descending in case `order_desc` is not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (8c9d84c) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.76%`.
> The diff coverage is `46.66%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.82% +13.76%
===========================================
Files 489 490 +1
Lines 17314 28874 +11560
Branches 4482 0 -4482
===========================================
+ Hits 9187 19296 +10109
- Misses 8127 9578 +1451
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.82% <46.66%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.28% <4.16%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [superset-frontend/src/modules/AnnotationTypes.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21vZHVsZXMvQW5ub3RhdGlvblR5cGVzLmpz) | | |
| [superset-frontend/src/api/dataset.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FwaS9kYXRhc2V0LnRz) | | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | | |
| [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
| ... and [966 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...eac18e3](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r573827235
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
I am curious, why use this control in a not time-series chart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (0d3420e) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `14.29%`.
> The diff coverage is `64.28%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 67.35% +14.29%
===========================================
Files 489 489
Lines 17314 28788 +11474
Branches 4482 0 -4482
===========================================
+ Hits 9187 19390 +10203
- Misses 8127 9398 +1271
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `67.35% <64.28%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `58.84% <0.00%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | | |
| [...t-frontend/src/dashboard/util/setPeriodicRunner.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NldFBlcmlvZGljUnVubmVyLnRz) | | |
| [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | | |
| ... and [965 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...0d3420e](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574181082
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
Or we can keep it as `timeseries_limit_metric` to be able to reuse the existing code and do a wholesale migration later.
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
Review comment:
cc @villebro what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #13057: feat: Add sort by metric for pivot-table
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r574215654
##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
raise QueryObjectValidationError(_("Please choose at least one metric"))
if set(groupby) & set(columns):
raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+ sort_by = self.form_data.get("timeseries_limit_metric")
+ if sort_by:
+ sort_by_label = utils.get_metric_name(sort_by)
+ if sort_by_label not in d["metrics"]:
+ d["metrics"].append(sort_by)
+ d["orderby"] = [(sort_by, not self.form_data.get("order_desc", True))]
Review comment:
thanks for the explanation, it's my fault
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-779328715
@villebro those changes are relatively low risk, instead of pulling each PR, I will take a look once they are on master all at once. 🟢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13057:
URL: https://github.com/apache/superset/pull/13057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13057: feat: Add sort by metric for charts with multiple metrics
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13057:
URL: https://github.com/apache/superset/pull/13057#issuecomment-776759612
# [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=h1) Report
> Merging [#13057](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=desc) (61349b9) into [master](https://codecov.io/gh/apache/superset/commit/2ce79823dfad61bce6196fcacd56a844f44818c0?el=desc) (2ce7982) will **increase** coverage by `13.86%`.
> The diff coverage is `30.63%`.
[](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13057 +/- ##
===========================================
+ Coverage 53.06% 66.92% +13.86%
===========================================
Files 489 491 +2
Lines 17314 29009 +11695
Branches 4482 0 -4482
===========================================
+ Hits 9187 19414 +10227
- Misses 8127 9595 +1468
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| python | `66.92% <30.63%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.68% <ø> (ø)` | |
| [...s/260bf0649a77\_migrate\_x\_dateunit\_in\_time\_range.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8yNjBiZjA2NDlhNzdfbWlncmF0ZV94X2RhdGV1bml0X2luX3RpbWVfcmFuZ2UucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `56.94% <9.33%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `92.85% <77.77%> (ø)` | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `89.74% <93.75%> (ø)` | |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `96.87% <100.00%> (ø)` | |
| [...s/controls/DateFilterControl/frame/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9mcmFtZS9Db21tb25GcmFtZS50c3g=) | | |
| [...t-frontend/src/explore/actions/saveModalActions.js](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvYWN0aW9ucy9zYXZlTW9kYWxBY3Rpb25zLmpz) | | |
| [...rontend/src/messageToasts/enhancers/withToasts.tsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvZW5oYW5jZXJzL3dpdGhUb2FzdHMudHN4) | | |
| [...src/dashboard/components/gridComponents/Column.jsx](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NvbHVtbi5qc3g=) | | |
| ... and [967 more](https://codecov.io/gh/apache/superset/pull/13057/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=footer). Last update [3e0681b...61349b9](https://codecov.io/gh/apache/superset/pull/13057?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org