You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/05/11 23:25:42 UTC
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6870
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
[webui] Improvements for when there's many tablets & cleanup
This patch makes a couple of improvements to the ui when there's
a lot of tablets:
1. /tablets displays a summary of the tablets' statuses.
2. /tablets has a toggle-collapse detailed table of tablets.
3. /table displays of summary of the tablets' statuses before the
tablet table.
4. /table has a toggle-collapse detailed table of tablets.
4. Detailed tablet tables use table-hover so it's easier to
use the table to look up information by, e.g. id.
All of these changes should help address KUDU-1974 and
KUDU-1959, by making it easier to see the overall health and
status of a table or tablet server's tablets.
Additionally, I found that many tables were not using the
<thead> and <tbody> elements, which caused some bootstrap
table styles not to be working as intended. All tables where
this was a problem have been fixed.
Also I added a memory usage column to the detailed tablets
table on /tablets.
Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/util/thread.cc
6 files changed, 123 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/6870/1
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6870
to look at the new patch set (#3).
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
[webui] Improvements for when there's many tablets & cleanup
This patch makes several improvements to the ui when there's
a lot of tablets:
1. /tablets displays a summary of the tablets' statuses.
2. /tablets has a toggle-collapse detailed table of tablets.
3. /table displays of summary of the tablets' statuses before the
tablet table.
4. /table has a toggle-collapse detailed table of tablets.
5. Detailed tablet tables use table-hover so it's easier to
use the table to look up information by, e.g. id.
All of these changes should help address KUDU-1974 and
KUDU-1959, by making it easier to see the overall health and
status of a table or tablet server's tablets.
Additionally, I found that many tables were not using the
<thead> and <tbody> elements, which caused some bootstrap
table styles not to be working as intended. All tables where
this was a problem have been fixed.
Also I added a memory usage column to the detailed tablets
table on /tablets.
Scrrenshots: http://imgur.com/a/Mmfbe
Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/util/thread.cc
6 files changed, 130 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/6870/3
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
[webui] Improvements for when there's many tablets & cleanup
This patch makes several improvements to the ui when there's
a lot of tablets:
1. /tablets displays a summary of the tablets' statuses.
2. /tablets has a toggle-collapse detailed table of tablets.
3. /table displays of summary of the tablets' statuses before the
tablet table.
4. /table has a toggle-collapse detailed table of tablets.
5. Detailed tablet tables use table-hover so it's easier to
use the table to look up information by, e.g. id.
All of these changes should help address KUDU-1974 and
KUDU-1959, by making it easier to see the overall health and
status of a table or tablet server's tablets.
Additionally, I found that many tables were not using the
<thead> and <tbody> elements, which caused some bootstrap
table styles not to be working as intended. All tables where
this was a problem have been fixed.
Also I added a memory usage column to the detailed tablets
table on /tablets.
Scrrenshots: http://imgur.com/a/Mmfbe
Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Reviewed-on: http://gerrit.cloudera.org:8080/6870
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/util/thread.cc
6 files changed, 130 insertions(+), 59 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:
Line 13: 2. /tablets has a toggle-collapse detailed table of tablets.
> There's 4 possible elements in the tablets section
I see, thanks for the clarification.
Line 29: Also I added a memory usage column to the detailed tablets
> It's not too jargony if it's correct and avoids the number being misleading
That's definitely correct for the block cache, but I'll let Adar answer for WAL usage since I'm not sure.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3: Code-Review+1
Thanks for the link to your cluster. The toggle-collapse stuff looks pretty good. Would like to see sorting on the columns but it's understandable if that's a lot more work.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(but that can be for the future)
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:
Line 13: 2. /tablets has a toggle-collapse detailed table of tablets.
> I'm not sure this is an improvement, since there is no content under the ta
There's 4 possible elements in the tablets section
1. summary of live tablets
2. table of live tablets
3. summary of tombstoned tablet
4. table of tombstoned tablets
so having the tablets tables collapsed shows the 1-2 summaries. Previously, if there were tombstoned tablets, info about them would be hidden below the live tablets table.
Line 29: Also I added a memory usage column to the detailed tablets
> I'm concerned it may be misleading to call this 'memory usage', since it on
It's not too jargony if it's correct and avoids the number being misleading. But I'm not familiar with how the mem trackers are working-- is it only tracking the write buffers because block caches, logs, etc are owned by different trackers?
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6870
to look at the new patch set (#2).
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
[webui] Improvements for when there's many tablets & cleanup
This patch makes several improvements to the ui when there's
a lot of tablets:
1. /tablets displays a summary of the tablets' statuses.
2. /tablets has a toggle-collapse detailed table of tablets.
3. /table displays of summary of the tablets' statuses before the
tablet table.
4. /table has a toggle-collapse detailed table of tablets.
5. Detailed tablet tables use table-hover so it's easier to
use the table to look up information by, e.g. id.
All of these changes should help address KUDU-1974 and
KUDU-1959, by making it easier to see the overall health and
status of a table or tablet server's tablets.
Additionally, I found that many tables were not using the
<thead> and <tbody> elements, which caused some bootstrap
table styles not to be working as intended. All tables where
this was a problem have been fixed.
Also I added a memory usage column to the detailed tablets
table on /tablets.
Scrrenshots: http://imgur.com/a/Mmfbe
Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/util/thread.cc
6 files changed, 131 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/6870/2
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
> Adar, do you have any opinion on 'write buffer memory usage' vs
> plain 'memory usage'?
Not beyond bikeshedding, no. :)
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
I agree that having the columns be sortable would be excellent, then we could by default limit the table to something like 10 rows and allow the sort to determine the top 10 rows, and have the toggle button expand from there.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(2 comments)
Thanks for doing this! Definitely a step forward in usability.
http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:
Line 13: 2. /tablets has a toggle-collapse detailed table of tablets.
I'm not sure this is an improvement, since there is no content under the tablets list. Seems like most of the time we will be clicking expand anyway. On the tables page it makes sense, in order to get a view of what's under that tables list.
Line 29: Also I added a memory usage column to the detailed tablets
I'm concerned it may be misleading to call this 'memory usage', since it only accounts for the write buffers. What do you think about calling it 'write buffer memory usage'? Too jargony?
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6870/1//COMMIT_MSG
Commit Message:
Line 17: 4. Detailed tablet tables use table-hover so it's easier to
> 5.
Done
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
Line 256: TabletMetadataLock l(tablet.get(), TabletMetadataLock::READ);
> Would it be possible to combine all of this with the work in L278+ to avoid
Done
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
Line 424: " <script src='/jquery-1.11.1.min.js' defer></script>"
> I noticed we include this already in www/metrics.html. Should we remove it
They get different headers-- metrics.html's is hard-coded.
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/tserver/tserver-path-handlers.cc
File src/kudu/tserver/tserver-path-handlers.cc:
PS1, Line 243: replica->tablet()->mem_tracker()
> Can this actually be null?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
Adar, do you have any opinion on 'write buffer memory usage' vs plain 'memory usage'?
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:
Line 29: Also I added a memory usage column to the detailed tablets
> I'm concerned it may be misleading to call this 'memory usage', since it on
Done
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
It is a bit more work- either rolling some javascript or picking and integrating the right jQuery plugin. Expect it to happen in the not-so-distant future, though.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 1:
(4 comments)
Do the pages look OK and load reasonably quickly when the number of tablets is high (say, 1000+)?
http://gerrit.cloudera.org:8080/#/c/6870/1//COMMIT_MSG
Commit Message:
Line 17: 4. Detailed tablet tables use table-hover so it's easier to
5.
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/master/master-path-handlers.cc
File src/kudu/master/master-path-handlers.cc:
Line 256: TabletMetadataLock l(tablet.get(), TabletMetadataLock::READ);
Would it be possible to combine all of this with the work in L278+ to avoid locking the tablets twice?
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
Line 424: " <script src='/jquery-1.11.1.min.js' defer></script>"
I noticed we include this already in www/metrics.html. Should we remove it from there? Or does the page header not get applied to that page?
http://gerrit.cloudera.org:8080/#/c/6870/1/src/kudu/tserver/tserver-path-handlers.cc
File src/kudu/tserver/tserver-path-handlers.cc:
PS1, Line 243: replica->tablet()->mem_tracker()
Can this actually be null?
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
OK well I'm in favor of 'write buffer memory usage'. I just think it's really likely that people will look at the page, add up the amounts, and get confused when it's only 1/2 of the server memory usage.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6870
to look at the new patch set (#4).
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
[webui] Improvements for when there's many tablets & cleanup
This patch makes several improvements to the ui when there's
a lot of tablets:
1. /tablets displays a summary of the tablets' statuses.
2. /tablets has a toggle-collapse detailed table of tablets.
3. /table displays of summary of the tablets' statuses before the
tablet table.
4. /table has a toggle-collapse detailed table of tablets.
5. Detailed tablet tables use table-hover so it's easier to
use the table to look up information by, e.g. id.
All of these changes should help address KUDU-1974 and
KUDU-1959, by making it easier to see the overall health and
status of a table or tablet server's tablets.
Additionally, I found that many tables were not using the
<thead> and <tbody> elements, which caused some bootstrap
table styles not to be working as intended. All tables where
this was a problem have been fixed.
Also I added a memory usage column to the detailed tablets
table on /tablets.
Scrrenshots: http://imgur.com/a/Mmfbe
Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
---
M src/kudu/master/master-path-handlers.cc
M src/kudu/server/default-path-handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webui_util.cc
M src/kudu/tserver/tserver-path-handlers.cc
M src/kudu/util/thread.cc
6 files changed, 130 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/6870/4
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6870/3//COMMIT_MSG
Commit Message:
Line 29: Also I added a memory usage column to the detailed tablets
> That's definitely correct for the block cache, but I'll let Adar answer for
AFAIK WAL buffers aren't tracked by memtrackers. The log index cache is, but its tracker isn't parented to the tablet's tracker.
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No
[kudu-CR] [webui] Improvements for when there's many tablets & cleanup
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [webui] Improvements for when there's many tablets & cleanup
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6870
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3904a4b0fbb6446615cd46c8a6f30f81c832c53
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No