You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/03 05:53:57 UTC

[GitHub] [apisix-dashboard] Si-ege opened a new pull request #2359: feat: Modify plugin preview page

Si-ege opened a new pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   Please update this section with detailed description.
   
   **Related issues**
   
   fix/resolve #1991
   1.The preview page shows only the activated plug-ins.
   
   **Checklist:**
   
   - [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Si-ege commented on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
Si-ege commented on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1065852626


   <img width="1625" alt="image" src="https://user-images.githubusercontent.com/92985804/158013130-f2f8fd95-6fc7-4548-8927-a6132f60ff0d.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r825272252



##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -88,6 +91,8 @@ context('Create Configure and Delete PluginTemplate', () => {
     cy.get(selector.description).clear().type(data.pluginTemplateName2);
     cy.contains('Next').click();
     cy.contains('Next').click();
+    cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+    cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');

Review comment:
       ditto

##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -74,6 +75,8 @@ context('Create Configure and Delete PluginTemplate', () => {
 
     cy.contains('Submit').click();
     cy.contains('Next').click();
+    cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+    cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');

Review comment:
       We'd better add assertions to determine that other category plugins don't exist

##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -92,6 +92,14 @@ const PluginPage: React.FC<Props> = ({
       form.setFieldsValue({ plugin_config_id });
     });
   }, []);
+  console.log('initialData: ', initialData);

Review comment:
       please remove this console




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r825280126



##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -74,6 +75,17 @@ context('Create Configure and Delete PluginTemplate', () => {
 
     cy.contains('Submit').click();
     cy.contains('Next').click();
+    cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+    cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');
+    cy.contains(
+      selector.pluginTitle,
+      'Security',
+      'Traffic Control',
+      'Serverless',
+      'Observability',
+      'Other',

Review comment:
       I'm not sure this is the right way to write them, should we split them into 5 assertions




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1065031207


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2359](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (da35f96) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/abefe97ccb4f4252b1790003acec1fb9a6f5dc05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abefe97) will **increase** coverage by `0.53%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2359      +/-   ##
   ==========================================
   + Coverage   68.12%   68.66%   +0.53%     
   ==========================================
     Files         127      131       +4     
     Lines        3379     3427      +48     
     Branches      832      831       -1     
   ==========================================
   + Hits         2302     2353      +51     
   + Misses       1077     1074       -3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.66% <100.00%> (+0.53%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.82% <100.00%> (+0.08%)` | :arrow_up: |
   | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | `71.42% <0.00%> (-1.08%)` | :arrow_down: |
   | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | `94.11% <0.00%> (-0.76%)` | :arrow_down: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <0.00%> (ø)` | |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <0.00%> (ø)` | |
   | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [...b/src/pages/Proto/components/ProtoDrawer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9jb21wb25lbnRzL1Byb3RvRHJhd2VyL2luZGV4LnRzeA==) | `88.46% <0.00%> (ø)` | |
   | [web/src/pages/Proto/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9MaXN0LnRzeA==) | `96.15% <0.00%> (ø)` | |
   | [web/src/pages/Proto/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9zZXJ2aWNlLnRz) | `100.00% <0.00%> (ø)` | |
   | [web/src/hooks/usePagination.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9ob29rcy91c2VQYWdpbmF0aW9uLnRz) | `100.00% <0.00%> (ø)` | |
   | ... and [7 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [abefe97...da35f96](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1065031207


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2359](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b273885) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/abefe97ccb4f4252b1790003acec1fb9a6f5dc05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abefe97) will **increase** coverage by `0.54%`.
   > The diff coverage is `94.84%`.
   
   > :exclamation: Current head b273885 differs from pull request most recent head f758aa1. Consider uploading reports for the commit f758aa1 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2359      +/-   ##
   ==========================================
   + Coverage   68.12%   68.66%   +0.54%     
   ==========================================
     Files         127      131       +4     
     Lines        3379     3428      +49     
     Branches      832      831       -1     
   ==========================================
   + Hits         2302     2354      +52     
   + Misses       1077     1074       -3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.66% <94.84%> (+0.54%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/data.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9kYXRhLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <ø> (ø)` | |
   | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <ø> (ø)` | |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <50.00%> (ø)` | |
   | [...b/src/pages/Proto/components/ProtoDrawer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9jb21wb25lbnRzL1Byb3RvRHJhd2VyL2luZGV4LnRzeA==) | `88.46% <88.46%> (ø)` | |
   | [web/src/pages/Proto/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9MaXN0LnRzeA==) | `96.15% <96.15%> (ø)` | |
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.83% <100.00%> (+0.10%)` | :arrow_up: |
   | [web/src/hooks/usePagination.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9ob29rcy91c2VQYWdpbmF0aW9uLnRz) | `100.00% <100.00%> (ø)` | |
   | [web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==) | `88.88% <100.00%> (+1.38%)` | :arrow_up: |
   | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | `71.42% <100.00%> (-1.08%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [abefe97...f758aa1](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Baoyuantop commented on a change in pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r825536650



##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -92,6 +92,13 @@ const PluginPage: React.FC<Props> = ({
       form.setFieldsValue({ plugin_config_id });
     });
   }, []);
+  const openPlugin = pluginList.filter(
+    (item) => initialData[item.name] && !initialData[item.name].disable,
+  );
+  const openPluginType = openPlugin.map((item) => item.type);
+  const newOpenPluginType = openPluginType.filter((elem, index, self) => {
+    return index === self.indexOf(elem);
+  });

Review comment:
       Can you explain it? I'm a little confused.

##########
File path: web/cypress/integration/pluginTemplate/create-edit-delete-plugin-template.spec.js
##########
@@ -74,6 +75,8 @@ context('Create Configure and Delete PluginTemplate', () => {
 
     cy.contains('Submit').click();
     cy.contains('Next').click();
+    cy.contains(selector.pluginCard, 'basic-auth').should('be.visible');
+    cy.contains(selector.pluginTitle, 'Authentication').should('be.visible');

Review comment:
       not exist or not visible?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1065031207


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2359](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3e7a4c1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/abefe97ccb4f4252b1790003acec1fb9a6f5dc05?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (abefe97) will **increase** coverage by `0.44%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2359      +/-   ##
   ==========================================
   + Coverage   68.12%   68.57%   +0.44%     
   ==========================================
     Files         127      131       +4     
     Lines        3379     3427      +48     
     Branches      832      831       -1     
   ==========================================
   + Hits         2302     2350      +48     
     Misses       1077     1077              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `68.57% <100.00%> (+0.44%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/components/Plugin/PluginPage.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5QYWdlLnRzeA==) | `98.82% <100.00%> (+0.08%)` | :arrow_up: |
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | [web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==) | `71.42% <0.00%> (-1.08%)` | :arrow_down: |
   | [web/src/pages/Service/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0xpc3QudHN4) | `94.11% <0.00%> (-0.76%)` | :arrow_down: |
   | [web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4) | `82.69% <0.00%> (ø)` | |
   | [web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | `100.00% <0.00%> (ø)` | |
   | [web/src/pages/Proto/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9MaXN0LnRzeA==) | `96.15% <0.00%> (ø)` | |
   | [web/src/pages/Proto/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9zZXJ2aWNlLnRz) | `100.00% <0.00%> (ø)` | |
   | [web/src/hooks/usePagination.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9ob29rcy91c2VQYWdpbmF0aW9uLnRz) | `100.00% <0.00%> (ø)` | |
   | [...b/src/pages/Proto/components/ProtoDrawer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Qcm90by9jb21wb25lbnRzL1Byb3RvRHJhd2VyL2luZGV4LnRzeA==) | `88.46% <0.00%> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2359/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [abefe97...3e7a4c1](https://codecov.io/gh/apache/apisix-dashboard/pull/2359?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r820335536



##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -179,66 +183,131 @@ const PluginPage: React.FC<Props> = ({
             />
           </>
         )}
-        {typeList.map((typeItem) => {
-          return (
-            <PanelSection
-              title={formatMessage({ id: `component.plugin.${typeItem}` })}
-              key={typeItem}
-              style={PanelSectionStyle}
-              id={`plugin-category-${typeItem}`}
-            >
-              {orderBy(
-                pluginList.filter((item) => item.type === typeItem.toLowerCase() && !item.hidden),
-                'name',
-                'asc',
-              ).map((item) => (
-                <Card
-                  key={item.name}
-                  actions={[
-                    <Button
-                      type={
-                        initialData[item.name] && !initialData[item.name].disable
-                          ? 'primary'
-                          : 'default'
-                      }
-                      danger={initialData[item.name] && !initialData[item.name].disable}
-                      onClick={() => {
-                        setName(item.name);
+        {readonly
+          ? new_openPluginType.map((typeItem) => {

Review comment:
       We can update dom automatically by changing the source data 😄




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1065846269


   Hi, @Si-ege can you add some images for this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#issuecomment-1066092148


   also cc @Baoyuantop PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #2359: feat: Modify plugin preview page

Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #2359:
URL: https://github.com/apache/apisix-dashboard/pull/2359#discussion_r833075000



##########
File path: web/src/components/Plugin/PluginPage.tsx
##########
@@ -92,6 +92,13 @@ const PluginPage: React.FC<Props> = ({
       form.setFieldsValue({ plugin_config_id });
     });
   }, []);
+  const openPlugin = pluginList.filter(

Review comment:
       `openPlugin` is Not a good variable name, It should be a list, for example: `openPluginList`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org