You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/05 08:15:08 UTC

[GitHub] [kafka] shayelkin opened a new pull request #11180: MINOR: Fix testResolveDnsLookupResolveCanonicalBootstrapServers

shayelkin opened a new pull request #11180:
URL: https://github.com/apache/kafka/pull/11180


   testResolveDnsLookupResolveCanonicalBootstrapServers added in https://github.com/apache/kafka/pull/11091 treats the result from ClientUtils.resolve() when using specifying RESOLVE_CANONICAL_BOOTSTRAP_SERVERS_ONLY as if it should differ from when specifying DEFAULT, yet the branching in resolve() is on ClientDnsLookup.USE_ALL_DNS_IPS == clientDnsLookup -- everything else gets the result squashed to a singletonList.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma merged pull request #11180: MINOR: Fix testResolveDnsLookupResolveCanonicalBootstrapServers

Posted by GitBox <gi...@apache.org>.
ijuma merged pull request #11180:
URL: https://github.com/apache/kafka/pull/11180


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #11180: MINOR: Fix testResolveDnsLookupResolveCanonicalBootstrapServers

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #11180:
URL: https://github.com/apache/kafka/pull/11180#issuecomment-894560131


   Thanks for the PR. I ran this test before pushing the cherry-pick, so not sure what happened.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org