[jira] Closed: (DIRSERVER-1568) LdifFileLoader#execute() always logs the LdapDN as "null"

["Felix Knecht (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DIRSERVER-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Knecht closed DIRSERVER-1568.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-RC1
         Assignee: Felix Knecht

Thanks Andrew for pointing.
Fix in http://svn.apache.org/viewvc?rev=1028324&view=rev

> LdifFileLoader#execute() always logs the LdapDN as "null"
> ---------------------------------------------------------
>
>                 Key: DIRSERVER-1568
>                 URL: https://issues.apache.org/jira/browse/DIRSERVER-1568
>             Project: Directory ApacheDS
>          Issue Type: Bug
>          Components: ldap
>    Affects Versions: 1.5.7
>            Reporter: Andrew Swan
>            Assignee: Felix Knecht
>            Priority: Minor
>             Fix For: 2.0.0-RC1
>
>
> The method LdifFileLoader#execute has a local variable of type LdapDN called "rdn". It's referenced three times:
> 1. Declared on line 174:
>     LdapDN rdn = null;
> 2. Used on line 198:
>     log.info( "Found {}, will not create.", rdn );
> 3. Used again on line 208:
>     log.info( "Created {}.", rdn );
> However because it is never assigned to anything, the log messages generated above will always say either  "Found null, will not create." or  "Created null.", both of which are rather misleading, especially in the "Created" case, when it appears to the user that there has been a problem loading the file.
> This bug is present in the trunk as well as the 1.5.7 tag.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.