[GitHub] [accumulo] ctubbsii commented on pull request #2410: Fix MiniAccumuloClusterImpl.verifyUp()

[GitBox <gi...@apache.org>]

ctubbsii commented on pull request #2410:
URL: https://github.com/apache/accumulo/pull/2410#issuecomment-1007659778


   @dlmarion Apparently, this fixed it for most of the tests, but there's at least one test that this breaks that I'll have to figure out: AccumuloClientIT.testClose asserts that we're in a CLIENT mode, but MiniAccumuloCluster specifically uses SERVER mode. The test passed before because mini lazily created a ServerContext that put it in SERVER mode. With these changes, the ServerContext is created sooner than it would have been.
   
   There's a few other tests that failed as a result of my fix as well (not anywhere near the 139 that were failing before, though), but those could just be flakes. I'd have to investigate. Including the one I already mentioned, the list is:
   
   ```
   org.apache.accumulo.test.functional.AccumuloClientIT.testClose
   org.apache.accumulo.test.functional.CleanUpIT.run
   org.apache.accumulo.test.functional.DurabilityIT.testIncreaseDurability
   org.apache.accumulo.test.functional.LateLastContactIT.test
   org.apache.accumulo.test.functional.ReadWriteIT.sunnyDay
   org.apache.accumulo.test.functional.RestartIT.restartManagerRecovery
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org