You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/10/30 14:08:33 UTC

Review Request 39814: Stack adviser error during using custom config group

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39814/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.


Bugs: AMBARI-13657
    https://issues.apache.org/jira/browse/AMBARI-13657


Repository: ambari


Description
-------

Steps:
Was created custom config group for Storm.
Assign host to created config group. Save changes.
Try to override "nimbus.monitor.freq.secs" (default config group is selected). Choose created config group in appeared window.
Result: 500-error in console.
/run/ambari-server/stack-recommendations/60/stackadvisor.err:
Traceback (most recent call last):
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
    main(sys.argv)
  File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
    result = stackAdvisor.recommendConfigurations(services, hosts)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 562, in recommendConfigurations
    servicesList)
  File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 505, in recommendConfigGroupsConfigurations
    calculation(configurations, cgClusterSummary, cgServices, cgHosts)
  File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.3/services/stack_advisor.py", line 220, in recommendHIVEConfigurations
    metadata_host = metadata_host_info['Hosts']['host_name']
TypeError: 'NoneType' object has no attribute '__getitem__'


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 1d1cdba 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py b755d46 

Diff: https://reviews.apache.org/r/39814/diff/


Testing
-------

Ran 249 tests in 7.957s

OK
----------------------------------------------------------------------
Total run:832
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen


Re: Review Request 39814: Stack adviser error during using custom config group

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39814/#review104564
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Жов. 30, 2015, 1:08 після полудня, Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39814/
> -----------------------------------------------------------
> 
> (Updated Жов. 30, 2015, 1:08 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-13657
>     https://issues.apache.org/jira/browse/AMBARI-13657
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> Was created custom config group for Storm.
> Assign host to created config group. Save changes.
> Try to override "nimbus.monitor.freq.secs" (default config group is selected). Choose created config group in appeared window.
> Result: 500-error in console.
> /run/ambari-server/stack-recommendations/60/stackadvisor.err:
> Traceback (most recent call last):
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 158, in <module>
>     main(sys.argv)
>   File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 109, in main
>     result = stackAdvisor.recommendConfigurations(services, hosts)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 562, in recommendConfigurations
>     servicesList)
>   File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 505, in recommendConfigGroupsConfigurations
>     calculation(configurations, cgClusterSummary, cgServices, cgHosts)
>   File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.3/services/stack_advisor.py", line 220, in recommendHIVEConfigurations
>     metadata_host = metadata_host_info['Hosts']['host_name']
> TypeError: 'NoneType' object has no attribute '__getitem__'
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 1d1cdba 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py b755d46 
> 
> Diff: https://reviews.apache.org/r/39814/diff/
> 
> 
> Testing
> -------
> 
> Ran 249 tests in 7.957s
> 
> OK
> ----------------------------------------------------------------------
> Total run:832
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>