[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table
URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r279107719
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java
 ##########
 @@ -109,6 +109,15 @@ public static void addSegments(
     );
   }
 
+  public static Map<String, VersionedIntervalTimeline<String, DataSegment>> buildTimelines(Iterable<DataSegment> segments)
 
 Review comment:
   This interface looks somewhat less intuitive because as this method also implies, `VersionedIntervalTimeline` is for each dataSource. I think it would be better to first group segments by their dataSources and then call `VersionedIntervalTimeline.forSegments` per dataSource. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org