You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Danny Chan <yu...@gmail.com> on 2020/02/26 05:23:09 UTC
[VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Hi all,
I have created a build for Apache Calcite 1.22.0, release candidate 2.
Thanks to everyone who has contributed to this release.
<Further details about release.> You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
Its hash is e397e47b0752c0647590097584903a9561a646eb.
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
The hashes of the artifacts are as follows:
src.tar.gz.sha512
049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a *apache-calcite-1.22.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1079
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/danny0405.asc
Please vote on releasing this package as Apache Calcite 1.22.0.
The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.22.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Best,
Danny Chan
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Rui Wang <am...@apache.org>.
"gpg --verify apache-calcite-1.22.0-src.zip.asc
apache-calcite-1.22.0-src.zip" is my understanding of how to verify the
signature.
I might have done it wrongly. Let's see how other people verify it.
-Rui
On Thu, Feb 27, 2020 at 7:50 PM Danny Chan <yu...@gmail.com> wrote:
> Why you verify the zip from a source distribution ? There is no key file
> there. I verify the zip files manually from
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>
> With command
> gpg --verify apache-calcite-1.22.0-src.zip.asc
> apache-calcite-1.22.0-src.zip
>
> And it outputs:
>
> gpg: 签名建立于 三 2/26 12:47:33 2020 CST
> gpg: 使用 RSA 密钥 9A48922F682AB05D1AE4A3E7C2931E4BDB03D5AE
> gpg: 完好的签名，来自于 “Danny Chan (yuzhao.cyz gpg) <yu...@gmail.com>” [绝对]
>
> Best,
> Danny Chan
> 在 2020年2月28日 +0800 AM5:13，Rui Wang <am...@apache.org>，写道：
> > Hi Danny,
> >
> > Thanks a lot for all Danny's contributions so far on this release!
> >
> > verified on platform: 5.2.17-1rodete3-amd64
> >
> > - calcite-1.22.0 tag has the right commit which is upon voting. OK
> > - check artifacts 512 hash (run sha512sum locally). OK
> >
> >
> > - run "./gradlew :assemble" from sources extracted from
> > apache-calcite-1.22.0-src.zip but cannot build from it:
> > Execution failed for task ':buildSrc:autostyleKotlinGradleCheck'.
> > - cannot verify signature on artifacts by: "gpg --verify
> > apache-calcite-1.22.0-src.zip.asc apache-calcite-1.22.0-src.zip"
> > gpg: Signature made Tue 25 Feb 2020 08:47:33 PM PST
> > gpg: using RSA key
> > 9A48922F682AB05D1AE4A3E7C2931E4BDB03D5AE
> > gpg: Can't check signature: No public key
> >
> >
> > -1 (non-binding)
> >
> > I will check again on my mac platform tonight.
> >
> > -Rui
> >
> >
> > On Thu, Feb 27, 2020 at 7:40 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
> >
> > > With the help of Stamatis
> > > we have created a reproducer
> > > the attached test case (in the last comment) fails on current master
> > > (and 1.22.0rc) but does not fail on 1.21
> > > so it can be considered a real regression
> > >
> > > Stamatis created a test case for Calcite code base, that can be used
> > > by a developer to fix the issue
> > > https://issues.apache.org/jira/browse/CALCITE-3826
> > >
> > > I am sorry I am not able to work on it these days
> > >
> > > Enrico
> > >
> > >
> > > Il giorno gio 27 feb 2020 alle ore 09:29 Julian Hyde
> > > <jh...@gmail.com> ha scritto:
> > > >
> > > > Danny
> > > >
> > > > I agree that a -1 is disheartening. Especially when given for
> mistaken
> > > reasons.
> > > >
> > > > Technically a -1 does not kill an RC. We just need 3 more +1 votes
> than
> > > -1 votes.
> > > >
> > > > I urge everyone to give detailed rationale for their vote. Even if
> you
> > > vote +1, describe what you checked.
> > > >
> > > > Julian
> > > >
> > > > > On Feb 26, 2020, at 03:14, Danny Chan <yu...@gmail.com>
> wrote:
> > > > >
> > > > > Gives a -1 when you are sure that it is a bug, or the voting would
> be
> > > very depressing, anyone can give a -1 for any reasons.
> > > > >
> > > > > Best,
> > > > > Danny Chan
> > > > > 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eolivelli@gmail.com
> >，写道：
> > > > > > Danny,
> > > > > > I have created
> https://issues.apache.org/jira/browse/CALCITE-3826
> > > > > > for the problem about bind variables in UPDATE statements.
> > > > > >
> > > > > > I feel this it can be a serious regression that can lead to data
> > > > > > corruption (wrong data type in DML statements).
> > > > > > AFAICT There is no way to workaround the problem in the
> application,
> > > > > > because Calcite produces a wrong model for the query.
> > > > > >
> > > > > > It seems to be a regression introduced in
> > > > > > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not
> sure.
> > > > > > we should confirm the bug and fix it or demonstrate that the bug
> is
> > > not valid
> > > > > >
> > > > > > -1 (non binding)
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > > > > > > <we...@gmail.com> ha scritto:
> > > > > > >
> > > > > > > Hi Danny,
> > > > > > > Thanks for your efforts.
> > > > > > >
> > > > > > > +1 (non-binding)
> > > > > > >
> > > > > > > Environment: Windows 7, JDK 1.8.0_121
> > > > > > > - Build and Test (./gradlew build) - OK
> > > > > > > - Checked Release Notes - OK
> > > > > > > - Checked README - OK
> > > > > > >
> > > > > > > Best,
> > > > > > > Feng
> > > > > > >
> > > > > > > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> > > > > > >
> > > > > > > > Hi all,
> > > > > > > >
> > > > > > > > I have created a build for Apache Calcite 1.22.0, release
> candidate
> > > 2.
> > > > > > > >
> > > > > > > > Thanks to everyone who has contributed to this release.
> > > > > > > > <Further details about release.> You can read the release
> notes
> > > here:
> > > > > > > >
> > >
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > > > > > > >
> > > > > > > > The commit to be voted upon:
> > > > > > > >
> > > > > > > >
> > >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > > > > > > >
> > > > > > > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > > > > > > >
> > > > > > > > The artifacts to be voted on are located here:
> > > > > > > >
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > > > > > > >
> > > > > > > > The hashes of the artifacts are as follows:
> > > > > > > > src.tar.gz.sha512
> > > > > > > >
> > > > > > > >
> > >
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > > > > > > *apache-calcite-1.22.0-src.tar.gz
> > > > > > > >
> > > > > > > > A staged Maven repository is available for review at:
> > > > > > > >
> > >
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > > > > > > >
> > > > > > > > Release artifacts are signed with the following key:
> > > > > > > > https://people.apache.org/keys/committer/danny0405.asc
> > > > > > > >
> > > > > > > > Please vote on releasing this package as Apache Calcite
> 1.22.0.
> > > > > > > >
> > > > > > > > The vote is open for the next 72 hours and passes if a
> majority of
> > > > > > > > at least three +1 PMC votes are cast.
> > > > > > > >
> > > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the
> release
> > > > > > > > [ ] -1 Do not release this package because...
> > > > > > > >
> > > > > > > > Here is my vote:
> > > > > > > >
> > > > > > > > +1 (binding)
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Danny Chan
> > > > > > > >
> > >
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
Why you verify the zip from a source distribution ? There is no key file there. I verify the zip files manually from
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
With command
gpg --verify apache-calcite-1.22.0-src.zip.asc apache-calcite-1.22.0-src.zip
And it outputs:
gpg: 签名建立于 三 2/26 12:47:33 2020 CST
gpg: 使用 RSA 密钥 9A48922F682AB05D1AE4A3E7C2931E4BDB03D5AE
gpg: 完好的签名，来自于 “Danny Chan (yuzhao.cyz gpg) <yu...@gmail.com>” [绝对]
Best,
Danny Chan
在 2020年2月28日 +0800 AM5:13，Rui Wang <am...@apache.org>，写道：
> Hi Danny,
>
> Thanks a lot for all Danny's contributions so far on this release!
>
> verified on platform: 5.2.17-1rodete3-amd64
>
> - calcite-1.22.0 tag has the right commit which is upon voting. OK
> - check artifacts 512 hash (run sha512sum locally). OK
>
>
> - run "./gradlew :assemble" from sources extracted from
> apache-calcite-1.22.0-src.zip but cannot build from it:
> Execution failed for task ':buildSrc:autostyleKotlinGradleCheck'.
> - cannot verify signature on artifacts by: "gpg --verify
> apache-calcite-1.22.0-src.zip.asc apache-calcite-1.22.0-src.zip"
> gpg: Signature made Tue 25 Feb 2020 08:47:33 PM PST
> gpg: using RSA key
> 9A48922F682AB05D1AE4A3E7C2931E4BDB03D5AE
> gpg: Can't check signature: No public key
>
>
> -1 (non-binding)
>
> I will check again on my mac platform tonight.
>
> -Rui
>
>
> On Thu, Feb 27, 2020 at 7:40 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> > With the help of Stamatis
> > we have created a reproducer
> > the attached test case (in the last comment) fails on current master
> > (and 1.22.0rc) but does not fail on 1.21
> > so it can be considered a real regression
> >
> > Stamatis created a test case for Calcite code base, that can be used
> > by a developer to fix the issue
> > https://issues.apache.org/jira/browse/CALCITE-3826
> >
> > I am sorry I am not able to work on it these days
> >
> > Enrico
> >
> >
> > Il giorno gio 27 feb 2020 alle ore 09:29 Julian Hyde
> > <jh...@gmail.com> ha scritto:
> > >
> > > Danny
> > >
> > > I agree that a -1 is disheartening. Especially when given for mistaken
> > reasons.
> > >
> > > Technically a -1 does not kill an RC. We just need 3 more +1 votes than
> > -1 votes.
> > >
> > > I urge everyone to give detailed rationale for their vote. Even if you
> > vote +1, describe what you checked.
> > >
> > > Julian
> > >
> > > > On Feb 26, 2020, at 03:14, Danny Chan <yu...@gmail.com> wrote:
> > > >
> > > > Gives a -1 when you are sure that it is a bug, or the voting would be
> > very depressing, anyone can give a -1 for any reasons.
> > > >
> > > > Best,
> > > > Danny Chan
> > > > 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> > > > > Danny,
> > > > > I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > > > > for the problem about bind variables in UPDATE statements.
> > > > >
> > > > > I feel this it can be a serious regression that can lead to data
> > > > > corruption (wrong data type in DML statements).
> > > > > AFAICT There is no way to workaround the problem in the application,
> > > > > because Calcite produces a wrong model for the query.
> > > > >
> > > > > It seems to be a regression introduced in
> > > > > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > > > > we should confirm the bug and fix it or demonstrate that the bug is
> > not valid
> > > > >
> > > > > -1 (non binding)
> > > > >
> > > > > Enrico
> > > > >
> > > > > > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > > > > > <we...@gmail.com> ha scritto:
> > > > > >
> > > > > > Hi Danny,
> > > > > > Thanks for your efforts.
> > > > > >
> > > > > > +1 (non-binding)
> > > > > >
> > > > > > Environment: Windows 7, JDK 1.8.0_121
> > > > > > - Build and Test (./gradlew build) - OK
> > > > > > - Checked Release Notes - OK
> > > > > > - Checked README - OK
> > > > > >
> > > > > > Best,
> > > > > > Feng
> > > > > >
> > > > > > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> > > > > >
> > > > > > > Hi all,
> > > > > > >
> > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate
> > 2.
> > > > > > >
> > > > > > > Thanks to everyone who has contributed to this release.
> > > > > > > <Further details about release.> You can read the release notes
> > here:
> > > > > > >
> > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > > > > > >
> > > > > > > The commit to be voted upon:
> > > > > > >
> > > > > > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > > > > > >
> > > > > > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > > > > > >
> > > > > > > The artifacts to be voted on are located here:
> > > > > > >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > > > > > >
> > > > > > > The hashes of the artifacts are as follows:
> > > > > > > src.tar.gz.sha512
> > > > > > >
> > > > > > >
> > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > > > > > *apache-calcite-1.22.0-src.tar.gz
> > > > > > >
> > > > > > > A staged Maven repository is available for review at:
> > > > > > >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > > > > > >
> > > > > > > Release artifacts are signed with the following key:
> > > > > > > https://people.apache.org/keys/committer/danny0405.asc
> > > > > > >
> > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > > > > > >
> > > > > > > The vote is open for the next 72 hours and passes if a majority of
> > > > > > > at least three +1 PMC votes are cast.
> > > > > > >
> > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > > > > [ ] -1 Do not release this package because...
> > > > > > >
> > > > > > > Here is my vote:
> > > > > > >
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > Best,
> > > > > > > Danny Chan
> > > > > > >
> >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Rui Wang <am...@apache.org>.
Hi Danny,
Thanks a lot for all Danny's contributions so far on this release!
verified on platform: 5.2.17-1rodete3-amd64
- calcite-1.22.0 tag has the right commit which is upon voting. OK
- check artifacts 512 hash (run sha512sum locally). OK
- run "./gradlew :assemble" from sources extracted from
apache-calcite-1.22.0-src.zip but cannot build from it:
Execution failed for task ':buildSrc:autostyleKotlinGradleCheck'.
- cannot verify signature on artifacts by: "gpg --verify
apache-calcite-1.22.0-src.zip.asc apache-calcite-1.22.0-src.zip"
gpg: Signature made Tue 25 Feb 2020 08:47:33 PM PST
gpg: using RSA key
9A48922F682AB05D1AE4A3E7C2931E4BDB03D5AE
gpg: Can't check signature: No public key
-1 (non-binding)
I will check again on my mac platform tonight.
-Rui
On Thu, Feb 27, 2020 at 7:40 AM Enrico Olivelli <eo...@gmail.com> wrote:
> With the help of Stamatis
> we have created a reproducer
> the attached test case (in the last comment) fails on current master
> (and 1.22.0rc) but does not fail on 1.21
> so it can be considered a real regression
>
> Stamatis created a test case for Calcite code base, that can be used
> by a developer to fix the issue
> https://issues.apache.org/jira/browse/CALCITE-3826
>
> I am sorry I am not able to work on it these days
>
> Enrico
>
>
> Il giorno gio 27 feb 2020 alle ore 09:29 Julian Hyde
> <jh...@gmail.com> ha scritto:
> >
> > Danny
> >
> > I agree that a -1 is disheartening. Especially when given for mistaken
> reasons.
> >
> > Technically a -1 does not kill an RC. We just need 3 more +1 votes than
> -1 votes.
> >
> > I urge everyone to give detailed rationale for their vote. Even if you
> vote +1, describe what you checked.
> >
> > Julian
> >
> > > On Feb 26, 2020, at 03:14, Danny Chan <yu...@gmail.com> wrote:
> > >
> > > Gives a -1 when you are sure that it is a bug, or the voting would be
> very depressing, anyone can give a -1 for any reasons.
> > >
> > > Best,
> > > Danny Chan
> > > 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> > >> Danny,
> > >> I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > >> for the problem about bind variables in UPDATE statements.
> > >>
> > >> I feel this it can be a serious regression that can lead to data
> > >> corruption (wrong data type in DML statements).
> > >> AFAICT There is no way to workaround the problem in the application,
> > >> because Calcite produces a wrong model for the query.
> > >>
> > >> It seems to be a regression introduced in
> > >> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > >> we should confirm the bug and fix it or demonstrate that the bug is
> not valid
> > >>
> > >> -1 (non binding)
> > >>
> > >> Enrico
> > >>
> > >>> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > >>> <we...@gmail.com> ha scritto:
> > >>>
> > >>> Hi Danny,
> > >>> Thanks for your efforts.
> > >>>
> > >>> +1 (non-binding)
> > >>>
> > >>> Environment: Windows 7, JDK 1.8.0_121
> > >>> - Build and Test (./gradlew build) - OK
> > >>> - Checked Release Notes - OK
> > >>> - Checked README - OK
> > >>>
> > >>> Best,
> > >>> Feng
> > >>>
> > >>> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> > >>>
> > >>>> Hi all,
> > >>>>
> > >>>> I have created a build for Apache Calcite 1.22.0, release candidate
> 2.
> > >>>>
> > >>>> Thanks to everyone who has contributed to this release.
> > >>>> <Further details about release.> You can read the release notes
> here:
> > >>>>
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > >>>>
> > >>>> The commit to be voted upon:
> > >>>>
> > >>>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > >>>>
> > >>>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > >>>>
> > >>>> The artifacts to be voted on are located here:
> > >>>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > >>>>
> > >>>> The hashes of the artifacts are as follows:
> > >>>> src.tar.gz.sha512
> > >>>>
> > >>>>
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > >>>> *apache-calcite-1.22.0-src.tar.gz
> > >>>>
> > >>>> A staged Maven repository is available for review at:
> > >>>>
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > >>>>
> > >>>> Release artifacts are signed with the following key:
> > >>>> https://people.apache.org/keys/committer/danny0405.asc
> > >>>>
> > >>>> Please vote on releasing this package as Apache Calcite 1.22.0.
> > >>>>
> > >>>> The vote is open for the next 72 hours and passes if a majority of
> > >>>> at least three +1 PMC votes are cast.
> > >>>>
> > >>>> [ ] +1 Release this package as Apache Calcite 1.22.0
> > >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > >>>> [ ] -1 Do not release this package because...
> > >>>>
> > >>>> Here is my vote:
> > >>>>
> > >>>> +1 (binding)
> > >>>>
> > >>>> Best,
> > >>>> Danny Chan
> > >>>>
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Enrico Olivelli <eo...@gmail.com>.
With the help of Stamatis
we have created a reproducer
the attached test case (in the last comment) fails on current master
(and 1.22.0rc) but does not fail on 1.21
so it can be considered a real regression
Stamatis created a test case for Calcite code base, that can be used
by a developer to fix the issue
https://issues.apache.org/jira/browse/CALCITE-3826
I am sorry I am not able to work on it these days
Enrico
Il giorno gio 27 feb 2020 alle ore 09:29 Julian Hyde
<jh...@gmail.com> ha scritto:
>
> Danny
>
> I agree that a -1 is disheartening. Especially when given for mistaken reasons.
>
> Technically a -1 does not kill an RC. We just need 3 more +1 votes than -1 votes.
>
> I urge everyone to give detailed rationale for their vote. Even if you vote +1, describe what you checked.
>
> Julian
>
> > On Feb 26, 2020, at 03:14, Danny Chan <yu...@gmail.com> wrote:
> >
> > Gives a -1 when you are sure that it is a bug, or the voting would be very depressing, anyone can give a -1 for any reasons.
> >
> > Best,
> > Danny Chan
> > 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> >> Danny,
> >> I have created https://issues.apache.org/jira/browse/CALCITE-3826
> >> for the problem about bind variables in UPDATE statements.
> >>
> >> I feel this it can be a serious regression that can lead to data
> >> corruption (wrong data type in DML statements).
> >> AFAICT There is no way to workaround the problem in the application,
> >> because Calcite produces a wrong model for the query.
> >>
> >> It seems to be a regression introduced in
> >> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> >> we should confirm the bug and fix it or demonstrate that the bug is not valid
> >>
> >> -1 (non binding)
> >>
> >> Enrico
> >>
> >>> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> >>> <we...@gmail.com> ha scritto:
> >>>
> >>> Hi Danny,
> >>> Thanks for your efforts.
> >>>
> >>> +1 (non-binding)
> >>>
> >>> Environment: Windows 7, JDK 1.8.0_121
> >>> - Build and Test (./gradlew build) - OK
> >>> - Checked Release Notes - OK
> >>> - Checked README - OK
> >>>
> >>> Best,
> >>> Feng
> >>>
> >>> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> >>>
> >>>> Hi all,
> >>>>
> >>>> I have created a build for Apache Calcite 1.22.0, release candidate 2.
> >>>>
> >>>> Thanks to everyone who has contributed to this release.
> >>>> <Further details about release.> You can read the release notes here:
> >>>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> >>>>
> >>>> The commit to be voted upon:
> >>>>
> >>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> >>>>
> >>>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
> >>>>
> >>>> The artifacts to be voted on are located here:
> >>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> >>>>
> >>>> The hashes of the artifacts are as follows:
> >>>> src.tar.gz.sha512
> >>>>
> >>>> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> >>>> *apache-calcite-1.22.0-src.tar.gz
> >>>>
> >>>> A staged Maven repository is available for review at:
> >>>> https://repository.apache.org/content/repositories/orgapachecalcite-1079
> >>>>
> >>>> Release artifacts are signed with the following key:
> >>>> https://people.apache.org/keys/committer/danny0405.asc
> >>>>
> >>>> Please vote on releasing this package as Apache Calcite 1.22.0.
> >>>>
> >>>> The vote is open for the next 72 hours and passes if a majority of
> >>>> at least three +1 PMC votes are cast.
> >>>>
> >>>> [ ] +1 Release this package as Apache Calcite 1.22.0
> >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> >>>> [ ] -1 Do not release this package because...
> >>>>
> >>>> Here is my vote:
> >>>>
> >>>> +1 (binding)
> >>>>
> >>>> Best,
> >>>> Danny Chan
> >>>>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Julian Hyde <jh...@gmail.com>.
Danny
I agree that a -1 is disheartening. Especially when given for mistaken reasons.
Technically a -1 does not kill an RC. We just need 3 more +1 votes than -1 votes.
I urge everyone to give detailed rationale for their vote. Even if you vote +1, describe what you checked.
Julian
> On Feb 26, 2020, at 03:14, Danny Chan <yu...@gmail.com> wrote:
>
> Gives a -1 when you are sure that it is a bug, or the voting would be very depressing, anyone can give a -1 for any reasons.
>
> Best,
> Danny Chan
> 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
>> Danny,
>> I have created https://issues.apache.org/jira/browse/CALCITE-3826
>> for the problem about bind variables in UPDATE statements.
>>
>> I feel this it can be a serious regression that can lead to data
>> corruption (wrong data type in DML statements).
>> AFAICT There is no way to workaround the problem in the application,
>> because Calcite produces a wrong model for the query.
>>
>> It seems to be a regression introduced in
>> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
>> we should confirm the bug and fix it or demonstrate that the bug is not valid
>>
>> -1 (non binding)
>>
>> Enrico
>>
>>> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
>>> <we...@gmail.com> ha scritto:
>>>
>>> Hi Danny,
>>> Thanks for your efforts.
>>>
>>> +1 (non-binding)
>>>
>>> Environment: Windows 7, JDK 1.8.0_121
>>> - Build and Test (./gradlew build) - OK
>>> - Checked Release Notes - OK
>>> - Checked README - OK
>>>
>>> Best,
>>> Feng
>>>
>>> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
>>>
>>>> Hi all,
>>>>
>>>> I have created a build for Apache Calcite 1.22.0, release candidate 2.
>>>>
>>>> Thanks to everyone who has contributed to this release.
>>>> <Further details about release.> You can read the release notes here:
>>>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>>>>
>>>> The commit to be voted upon:
>>>>
>>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
>>>>
>>>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
>>>>
>>>> The artifacts to be voted on are located here:
>>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>>>>
>>>> The hashes of the artifacts are as follows:
>>>> src.tar.gz.sha512
>>>>
>>>> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
>>>> *apache-calcite-1.22.0-src.tar.gz
>>>>
>>>> A staged Maven repository is available for review at:
>>>> https://repository.apache.org/content/repositories/orgapachecalcite-1079
>>>>
>>>> Release artifacts are signed with the following key:
>>>> https://people.apache.org/keys/committer/danny0405.asc
>>>>
>>>> Please vote on releasing this package as Apache Calcite 1.22.0.
>>>>
>>>> The vote is open for the next 72 hours and passes if a majority of
>>>> at least three +1 PMC votes are cast.
>>>>
>>>> [ ] +1 Release this package as Apache Calcite 1.22.0
>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>>> [ ] -1 Do not release this package because...
>>>>
>>>> Here is my vote:
>>>>
>>>> +1 (binding)
>>>>
>>>> Best,
>>>> Danny Chan
>>>>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno mer 26 feb 2020 alle ore 12:14 Danny Chan
<yu...@gmail.com> ha scritto:
>
> Gives a -1 when you are sure that it is a bug, or the voting would be very depressing, anyone can give a -1 for any reasons.
I am sorry.
I am doing my best in helping with the validation of the release, it
is in the interest of every one that the new release is stable.
I would like to see that there is no issue in Calcite and the problem
is in my application,.
I know the weight of a -1 (I have been release manager for a few
Apache projects and releases)
Btw my vote is "non binding",
It is up to you PMC to accept formally the release.
Enrico
>
> Best,
> Danny Chan
> 在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> > Danny,
> > I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > for the problem about bind variables in UPDATE statements.
> >
> > I feel this it can be a serious regression that can lead to data
> > corruption (wrong data type in DML statements).
> > AFAICT There is no way to workaround the problem in the application,
> > because Calcite produces a wrong model for the query.
> >
> > It seems to be a regression introduced in
> > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > we should confirm the bug and fix it or demonstrate that the bug is not valid
> >
> > -1 (non binding)
> >
> > Enrico
> >
> > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > <we...@gmail.com> ha scritto:
> > >
> > > Hi Danny,
> > > Thanks for your efforts.
> > >
> > > +1 (non-binding)
> > >
> > > Environment: Windows 7, JDK 1.8.0_121
> > > - Build and Test (./gradlew build) - OK
> > > - Checked Release Notes - OK
> > > - Checked README - OK
> > >
> > > Best,
> > > Feng
> > >
> > > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> > >
> > > > Hi all,
> > > >
> > > > I have created a build for Apache Calcite 1.22.0, release candidate 2.
> > > >
> > > > Thanks to everyone who has contributed to this release.
> > > > <Further details about release.> You can read the release notes here:
> > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > > >
> > > > The commit to be voted upon:
> > > >
> > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > > >
> > > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > > >
> > > > The artifacts to be voted on are located here:
> > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > > >
> > > > The hashes of the artifacts are as follows:
> > > > src.tar.gz.sha512
> > > >
> > > > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > > *apache-calcite-1.22.0-src.tar.gz
> > > >
> > > > A staged Maven repository is available for review at:
> > > > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > > >
> > > > Release artifacts are signed with the following key:
> > > > https://people.apache.org/keys/committer/danny0405.asc
> > > >
> > > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > > >
> > > > The vote is open for the next 72 hours and passes if a majority of
> > > > at least three +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > > > Here is my vote:
> > > >
> > > > +1 (binding)
> > > >
> > > > Best,
> > > > Danny Chan
> > > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
Gives a -1 when you are sure that it is a bug, or the voting would be very depressing, anyone can give a -1 for any reasons.
Best,
Danny Chan
在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> Danny,
> I have created https://issues.apache.org/jira/browse/CALCITE-3826
> for the problem about bind variables in UPDATE statements.
>
> I feel this it can be a serious regression that can lead to data
> corruption (wrong data type in DML statements).
> AFAICT There is no way to workaround the problem in the application,
> because Calcite produces a wrong model for the query.
>
> It seems to be a regression introduced in
> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> we should confirm the bug and fix it or demonstrate that the bug is not valid
>
> -1 (non binding)
>
> Enrico
>
> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> <we...@gmail.com> ha scritto:
> >
> > Hi Danny,
> > Thanks for your efforts.
> >
> > +1 (non-binding)
> >
> > Environment: Windows 7, JDK 1.8.0_121
> > - Build and Test (./gradlew build) - OK
> > - Checked Release Notes - OK
> > - Checked README - OK
> >
> > Best,
> > Feng
> >
> > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.22.0, release candidate 2.
> > >
> > > Thanks to everyone who has contributed to this release.
> > > <Further details about release.> You can read the release notes here:
> > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > >
> > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > >
> > > The hashes of the artifacts are as follows:
> > > src.tar.gz.sha512
> > >
> > > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > *apache-calcite-1.22.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/danny0405.asc
> > >
> > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of
> > > at least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Danny Chan
> > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
Replied in the JIRA issue, I tried to reproduce your case but failed, can you give one in Calcite, thanks.
Best,
Danny Chan
在 2020年2月26日 +0800 PM3:04，Enrico Olivelli <eo...@gmail.com>，写道：
> Danny,
> I have created https://issues.apache.org/jira/browse/CALCITE-3826
> for the problem about bind variables in UPDATE statements.
>
> I feel this it can be a serious regression that can lead to data
> corruption (wrong data type in DML statements).
> AFAICT There is no way to workaround the problem in the application,
> because Calcite produces a wrong model for the query.
>
> It seems to be a regression introduced in
> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> we should confirm the bug and fix it or demonstrate that the bug is not valid
>
> -1 (non binding)
>
> Enrico
>
> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> <we...@gmail.com> ha scritto:
> >
> > Hi Danny,
> > Thanks for your efforts.
> >
> > +1 (non-binding)
> >
> > Environment: Windows 7, JDK 1.8.0_121
> > - Build and Test (./gradlew build) - OK
> > - Checked Release Notes - OK
> > - Checked README - OK
> >
> > Best,
> > Feng
> >
> > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.22.0, release candidate 2.
> > >
> > > Thanks to everyone who has contributed to this release.
> > > <Further details about release.> You can read the release notes here:
> > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > >
> > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > >
> > > The hashes of the artifacts are as follows:
> > > src.tar.gz.sha512
> > >
> > > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > *apache-calcite-1.22.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/danny0405.asc
> > >
> > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of
> > > at least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Danny Chan
> > >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Enrico Olivelli <eo...@gmail.com>.
Il giorno mer 26 feb 2020 alle ore 08:10 Francis Chuang
<fr...@apache.org> ha scritto:
>
> Hey Enrico,
>
> If a regression was introduced and broke existing behavior and is not a
> breaking change, then it's probably something that we should fix before
> the release.
>
> Are you able to open a PR with a test case to confirm the bug so that it
> can be fixed?
I am trying to setup a new dev env because Gradle + Kotlin is not
supported by my IDE.
I guess it will take time.
The JIRA contains enough information and I am sure that a skilled
Calcite developer
is able to setup such test in a few minutes.
>
> The release is running a bit late already, so hopefully this won't be a
> complicated fix.
Yes, but it is worth to assess the problem, or we will deliver huge
problems to our clients
Enrico
>
> Francis
>
> On 26/02/2020 6:03 pm, Enrico Olivelli wrote:
> > Danny,
> > I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > for the problem about bind variables in UPDATE statements.
> >
> > I feel this it can be a serious regression that can lead to data
> > corruption (wrong data type in DML statements).
> > AFAICT There is no way to workaround the problem in the application,
> > because Calcite produces a wrong model for the query.
> >
> > It seems to be a regression introduced in
> > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > we should confirm the bug and fix it or demonstrate that the bug is not valid
> >
> > -1 (non binding)
> >
> > Enrico
> >
> > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > <we...@gmail.com> ha scritto:
> >>
> >> Hi Danny,
> >> Thanks for your efforts.
> >>
> >> +1 (non-binding)
> >>
> >> Environment: Windows 7, JDK 1.8.0_121
> >> - Build and Test (./gradlew build) - OK
> >> - Checked Release Notes - OK
> >> - Checked README - OK
> >>
> >> Best,
> >> Feng
> >>
> >> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> >>
> >>> Hi all,
> >>>
> >>> I have created a build for Apache Calcite 1.22.0, release candidate 2.
> >>>
> >>> Thanks to everyone who has contributed to this release.
> >>> <Further details about release.> You can read the release notes here:
> >>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> >>>
> >>> The commit to be voted upon:
> >>>
> >>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> >>>
> >>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
> >>>
> >>> The artifacts to be voted on are located here:
> >>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> >>>
> >>> The hashes of the artifacts are as follows:
> >>> src.tar.gz.sha512
> >>>
> >>> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> >>> *apache-calcite-1.22.0-src.tar.gz
> >>>
> >>> A staged Maven repository is available for review at:
> >>> https://repository.apache.org/content/repositories/orgapachecalcite-1079
> >>>
> >>> Release artifacts are signed with the following key:
> >>> https://people.apache.org/keys/committer/danny0405.asc
> >>>
> >>> Please vote on releasing this package as Apache Calcite 1.22.0.
> >>>
> >>> The vote is open for the next 72 hours and passes if a majority of
> >>> at least three +1 PMC votes are cast.
> >>>
> >>> [ ] +1 Release this package as Apache Calcite 1.22.0
> >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> >>> [ ] -1 Do not release this package because...
> >>>
> >>> Here is my vote:
> >>>
> >>> +1 (binding)
> >>>
> >>> Best,
> >>> Danny Chan
> >>>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
Sorry I would rather see it as not a regression, this is just our choice, if the plan changes:
Either
• There is physical node in the logical plan which should be fixed
• User Table does not implement a QueryableTable but a (ScannableTable | FilterableTable | ProjectableFilterableTable), but they still what a EnumerableTableScan, which is error prone for the reason I have illustrated in the EnumerableTableScan comments
To fix this, change your plan to the correct one or implement your Table correctly.
Best,
Danny Chan
在 2020年2月26日 +0800 PM3:16，Stamatis Zampetakis <za...@gmail.com>，写道：
> Anton also mentioned a regression related with CALCITE-3769 [1]. I think we
> should reach consensus for both CALCITE-3769 and CALCITE-3826 before moving
> forward with the release.
>
> [1] https://issues.apache.org/jira/browse/CALCITE-3769
>
> On Wed, Feb 26, 2020 at 8:10 AM Francis Chuang <fr...@apache.org>
> wrote:
>
> > Hey Enrico,
> >
> > If a regression was introduced and broke existing behavior and is not a
> > breaking change, then it's probably something that we should fix before
> > the release.
> >
> > Are you able to open a PR with a test case to confirm the bug so that it
> > can be fixed?
> >
> > The release is running a bit late already, so hopefully this won't be a
> > complicated fix.
> >
> > Francis
> >
> > On 26/02/2020 6:03 pm, Enrico Olivelli wrote:
> > > Danny,
> > > I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > > for the problem about bind variables in UPDATE statements.
> > >
> > > I feel this it can be a serious regression that can lead to data
> > > corruption (wrong data type in DML statements).
> > > AFAICT There is no way to workaround the problem in the application,
> > > because Calcite produces a wrong model for the query.
> > >
> > > It seems to be a regression introduced in
> > > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > > we should confirm the bug and fix it or demonstrate that the bug is not
> > valid
> > >
> > > -1 (non binding)
> > >
> > > Enrico
> > >
> > > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > > <we...@gmail.com> ha scritto:
> > > >
> > > > Hi Danny,
> > > > Thanks for your efforts.
> > > >
> > > > +1 (non-binding)
> > > >
> > > > Environment: Windows 7, JDK 1.8.0_121
> > > > - Build and Test (./gradlew build) - OK
> > > > - Checked Release Notes - OK
> > > > - Checked README - OK
> > > >
> > > > Best,
> > > > Feng
> > > >
> > > > Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> > > >
> > > > > Hi all,
> > > > >
> > > > > I have created a build for Apache Calcite 1.22.0, release candidate 2.
> > > > >
> > > > > Thanks to everyone who has contributed to this release.
> > > > > <Further details about release.> You can read the release notes here:
> > > > >
> > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> > > > >
> > > > > The commit to be voted upon:
> > > > >
> > > > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> > > > >
> > > > > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> > > > >
> > > > > The artifacts to be voted on are located here:
> > > > >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> > > > >
> > > > > The hashes of the artifacts are as follows:
> > > > > src.tar.gz.sha512
> > > > >
> > > > >
> > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > > > > *apache-calcite-1.22.0-src.tar.gz
> > > > >
> > > > > A staged Maven repository is available for review at:
> > > > >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> > > > >
> > > > > Release artifacts are signed with the following key:
> > > > > https://people.apache.org/keys/committer/danny0405.asc
> > > > >
> > > > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > > > >
> > > > > The vote is open for the next 72 hours and passes if a majority of
> > > > > at least three +1 PMC votes are cast.
> > > > >
> > > > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > > [ ] -1 Do not release this package because...
> > > > >
> > > > > Here is my vote:
> > > > >
> > > > > +1 (binding)
> > > > >
> > > > > Best,
> > > > > Danny Chan
> > > > >
> >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Stamatis Zampetakis <za...@gmail.com>.
Anton also mentioned a regression related with CALCITE-3769 [1]. I think we
should reach consensus for both CALCITE-3769 and CALCITE-3826 before moving
forward with the release.
[1] https://issues.apache.org/jira/browse/CALCITE-3769
On Wed, Feb 26, 2020 at 8:10 AM Francis Chuang <fr...@apache.org>
wrote:
> Hey Enrico,
>
> If a regression was introduced and broke existing behavior and is not a
> breaking change, then it's probably something that we should fix before
> the release.
>
> Are you able to open a PR with a test case to confirm the bug so that it
> can be fixed?
>
> The release is running a bit late already, so hopefully this won't be a
> complicated fix.
>
> Francis
>
> On 26/02/2020 6:03 pm, Enrico Olivelli wrote:
> > Danny,
> > I have created https://issues.apache.org/jira/browse/CALCITE-3826
> > for the problem about bind variables in UPDATE statements.
> >
> > I feel this it can be a serious regression that can lead to data
> > corruption (wrong data type in DML statements).
> > AFAICT There is no way to workaround the problem in the application,
> > because Calcite produces a wrong model for the query.
> >
> > It seems to be a regression introduced in
> > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> > we should confirm the bug and fix it or demonstrate that the bug is not
> valid
> >
> > -1 (non binding)
> >
> > Enrico
> >
> > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> > <we...@gmail.com> ha scritto:
> >>
> >> Hi Danny,
> >> Thanks for your efforts.
> >>
> >> +1 (non-binding)
> >>
> >> Environment: Windows 7, JDK 1.8.0_121
> >> - Build and Test (./gradlew build) - OK
> >> - Checked Release Notes - OK
> >> - Checked README - OK
> >>
> >> Best,
> >> Feng
> >>
> >> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> >>
> >>> Hi all,
> >>>
> >>> I have created a build for Apache Calcite 1.22.0, release candidate 2.
> >>>
> >>> Thanks to everyone who has contributed to this release.
> >>> <Further details about release.> You can read the release notes here:
> >>>
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> >>>
> >>> The commit to be voted upon:
> >>>
> >>>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> >>>
> >>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
> >>>
> >>> The artifacts to be voted on are located here:
> >>>
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> >>>
> >>> The hashes of the artifacts are as follows:
> >>> src.tar.gz.sha512
> >>>
> >>>
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> >>> *apache-calcite-1.22.0-src.tar.gz
> >>>
> >>> A staged Maven repository is available for review at:
> >>>
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
> >>>
> >>> Release artifacts are signed with the following key:
> >>> https://people.apache.org/keys/committer/danny0405.asc
> >>>
> >>> Please vote on releasing this package as Apache Calcite 1.22.0.
> >>>
> >>> The vote is open for the next 72 hours and passes if a majority of
> >>> at least three +1 PMC votes are cast.
> >>>
> >>> [ ] +1 Release this package as Apache Calcite 1.22.0
> >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> >>> [ ] -1 Do not release this package because...
> >>>
> >>> Here is my vote:
> >>>
> >>> +1 (binding)
> >>>
> >>> Best,
> >>> Danny Chan
> >>>
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Francis Chuang <fr...@apache.org>.
Hey Enrico,
If a regression was introduced and broke existing behavior and is not a
breaking change, then it's probably something that we should fix before
the release.
Are you able to open a PR with a test case to confirm the bug so that it
can be fixed?
The release is running a bit late already, so hopefully this won't be a
complicated fix.
Francis
On 26/02/2020 6:03 pm, Enrico Olivelli wrote:
> Danny,
> I have created https://issues.apache.org/jira/browse/CALCITE-3826
> for the problem about bind variables in UPDATE statements.
>
> I feel this it can be a serious regression that can lead to data
> corruption (wrong data type in DML statements).
> AFAICT There is no way to workaround the problem in the application,
> because Calcite produces a wrong model for the query.
>
> It seems to be a regression introduced in
> https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
> we should confirm the bug and fix it or demonstrate that the bug is not valid
>
> -1 (non binding)
>
> Enrico
>
> Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
> <we...@gmail.com> ha scritto:
>>
>> Hi Danny,
>> Thanks for your efforts.
>>
>> +1 (non-binding)
>>
>> Environment: Windows 7, JDK 1.8.0_121
>> - Build and Test (./gradlew build) - OK
>> - Checked Release Notes - OK
>> - Checked README - OK
>>
>> Best,
>> Feng
>>
>> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
>>
>>> Hi all,
>>>
>>> I have created a build for Apache Calcite 1.22.0, release candidate 2.
>>>
>>> Thanks to everyone who has contributed to this release.
>>> <Further details about release.> You can read the release notes here:
>>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>>>
>>> The commit to be voted upon:
>>>
>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
>>>
>>> Its hash is e397e47b0752c0647590097584903a9561a646eb.
>>>
>>> The artifacts to be voted on are located here:
>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>>>
>>> The hashes of the artifacts are as follows:
>>> src.tar.gz.sha512
>>>
>>> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
>>> *apache-calcite-1.22.0-src.tar.gz
>>>
>>> A staged Maven repository is available for review at:
>>> https://repository.apache.org/content/repositories/orgapachecalcite-1079
>>>
>>> Release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/danny0405.asc
>>>
>>> Please vote on releasing this package as Apache Calcite 1.22.0.
>>>
>>> The vote is open for the next 72 hours and passes if a majority of
>>> at least three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Calcite 1.22.0
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
>>>
>>> Here is my vote:
>>>
>>> +1 (binding)
>>>
>>> Best,
>>> Danny Chan
>>>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Enrico Olivelli <eo...@gmail.com>.
Danny,
I have created https://issues.apache.org/jira/browse/CALCITE-3826
for the problem about bind variables in UPDATE statements.
I feel this it can be a serious regression that can lead to data
corruption (wrong data type in DML statements).
AFAICT There is no way to workaround the problem in the application,
because Calcite produces a wrong model for the query.
It seems to be a regression introduced in
https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure.
we should confirm the bug and fix it or demonstrate that the bug is not valid
-1 (non binding)
Enrico
Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu
<we...@gmail.com> ha scritto:
>
> Hi Danny,
> Thanks for your efforts.
>
> +1 (non-binding)
>
> Environment: Windows 7, JDK 1.8.0_121
> - Build and Test (./gradlew build) - OK
> - Checked Release Notes - OK
> - Checked README - OK
>
> Best,
> Feng
>
> Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.22.0, release candidate 2.
> >
> > Thanks to everyone who has contributed to this release.
> > <Further details about release.> You can read the release notes here:
> > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
> >
> > Its hash is e397e47b0752c0647590097584903a9561a646eb.
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
> >
> > The hashes of the artifacts are as follows:
> > src.tar.gz.sha512
> >
> > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> > *apache-calcite-1.22.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> > https://repository.apache.org/content/repositories/orgapachecalcite-1079
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/danny0405.asc
> >
> > Please vote on releasing this package as Apache Calcite 1.22.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of
> > at least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.22.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Best,
> > Danny Chan
> >
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Feng Zhu <we...@gmail.com>.
Hi Danny,
Thanks for your efforts.
+1 (non-binding)
Environment: Windows 7, JDK 1.8.0_121
- Build and Test (./gradlew build) - OK
- Checked Release Notes - OK
- Checked README - OK
Best,
Feng
Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release candidate 2.
>
> Thanks to everyone who has contributed to this release.
> <Further details about release.> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
>
> Its hash is e397e47b0752c0647590097584903a9561a646eb.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha512
>
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
This is a long-overdue release, can we push it a little faster ? If we have any questions can we resolve it in release-1.23 which comes one month later, actually I have fixed many bugs when I do a local test with Apache Flink master with 1.22.0-SNAPSHOT, and in my opinion, it is qualified to be a release now ~
Best,
Danny Chan
在 2020年2月26日 +0800 PM1:23，Danny Chan <yu...@gmail.com>，写道：
> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release candidate 2.
>
> Thanks to everyone who has contributed to this release.
> <Further details about release.> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>
> The commit to be voted upon:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
>
> Its hash is e397e47b0752c0647590097584903a9561a646eb.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha512
>
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by JiaTao Tao <ta...@gmail.com>.
+1 (non-binding)
Regards!
Aron Tao
Danny Chan <yu...@gmail.com> 于2020年2月26日周三 下午1:23写道：
> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release candidate 2.
>
> Thanks to everyone who has contributed to this release.
> <Further details about release.> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb
>
> Its hash is e397e47b0752c0647590097584903a9561a646eb.
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
>
> The hashes of the artifacts are as follows:
> src.tar.gz.sha512
>
> 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a
> *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1079
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of
> at least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
Great, it seems I have missed these 2 properties:
asfGitSourceUsername=test
asfGitSourcePassword=test
Would have a try soon ~
Best,
Danny Chan
在 2020年3月2日 +0800 PM3:11，dev@calcite.apache.org，写道：
>
> asfGitSourceUsername=test
> asfGitSourcePassword=test
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Danny>Actually I do not know how to config the authentication for the
eclipse plugin that the Gradle task uses, is there any doc/instructions
that I can reference ?
I have never tried (I always release via command line like ./gradlew
prepareVote -Prc=2 -Pasf <-- it is just enough), however, the following
seems relevant:
https://discuss.gradle.org/t/eclipse-buildship-global-gradle-properties-not-read/18941
In other words: it should read .gradle/gradle.properties in your home
directory or in the directory that you configure in Eclipse (if you
configure an override there)
The properties are
asfNexusUsername=test
asfNexusPassword=test
asfGitSourceUsername=test
asfGitSourcePassword=test
asfSvnUsername=test
asfSvnPassword=test
signing.gnupg.keyName=289023DE2663BD17
# The following two options would use native gpg executable for signing (==
with gpg-agent support)
useGpgCmd=true
signing.gnupg.useLegacyGpg=true
# The following would configure Java's PGP signing implementation
signing.keyId=289023DE2663BD17
signing.password=qwerty
signing.secretKeyRingFile=.../.gnupg/secring.gpg
Danny>There is no rc tag in the Calcite repository
Because we have never released with Gradle yet.
-rc tags could be deleted after the vote passes.
However, a mere presence of -rc tags makes it obvious there's a vote
pending, and it avoids confusion whether calcite-1.22.0 tag is the release
tag or not.
$ git ls-remote origin | grep 1.22.0
e397e47b0752c0647590097584903a9561a646eb refs/tags/calcite-1.22.0
The current refs/tags/calcite-1.22.0 does look like a release tag, however,
it is not an official release yet.
Danny>we did has a tag for each release with pattern Calcite-1.22.0, so I
would not follow you in this part, the original work flow is ok for me.
Note: the final release tag name should have rel/ prefix.
This was a decision of the Board 3 years ago:
https://lists.apache.org/thread.html/6d9bc4a603214552804f4c4f8e3c7f0ae260556019b1414caf6f5825%401452448804%40%3Cprivate.calcite.apache.org%3E
Note: rel/... tags are immutable, and it would be extremely hard to delete
them.
So rel/... namespace should not be used for release candidate tags.
Here's the relevant quote from 6d9bc4a60321... email:
David>Second, we've changed the 'protected' portions of git to primarily
David>focus on refs/tags/rel - thus any tags under rel, will have their
David>entire commit history. This provides the provenance that the ASF needs
David>for releases, while still giving projects the ability to mold their
David>repository in the way they see fit.
David>Thus when a release vote is successful - part of the release process
David>should become tagging the voted upon commit SHA under rel/ to make it
David>indelible. ('# git tag rel/v15.4.2 ' or something similar.)
Vladimir
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
> What is the error message?
AFAIK it should not require credentials to create the tag, however, it
needs authentication to push the tag to the Git server.
Actually I do not know how to config the authentication for the eclipse plugin that the Gradle task uses, is there any doc/instructions that I can reference ? I can push the tag manually though.
>The difference is in the name. Autogenerated tags would be like v1.22-rc2
which has a clear tint of being a release candidate.
There is no rc tag in the Calcite repository, instead we have a release branch with pattern: branch-1.22.0, we did has a tag for each release with pattern Calcite-1.22.0, so I would not follow you in this part, the original work flow is ok for me.
Best,
Danny Chan
在 2020年3月1日 +0800 PM2:40，dev@calcite.apache.org，写道：
>
> What is the error message?
> AFAIK it should not require credentials to create the tag, however, it
> needs authentication to push the tag to the Git server.
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Vladimir Sitnikov <si...@gmail.com>.
>1. I did checked every tar/zip checksums before/after the release, would
write id down in the mail next time ~
Ok, it looks like I did not express it properly.
Danny>The artifacts to be voted on are located here:
Danny>
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/
The vote mail says nothing about apache-calcite-1.22.0-src.zip, so it means
that the release archives are invalid, so it means there's -1 until the
list of staged artifacts is sorted out.
It is important that "vote mail" sets the full expectation on the set of
released files.
Now there's a mismatch between the list of staged files and the list of
files in the vote.
>3. I did try the auto tag task from the Gradle prepareVote, but it fails
every time and reports the authentication problem when creating the tag
What is the error message?
AFAIK it should not require credentials to create the tag, however, it
needs authentication to push the tag to the Git server.
> what’s the difference then ? It is still a tag
The difference is in the name. Autogenerated tags would be like v1.22-rc2
which has a clear tint of being a release candidate.
>4. Would represent the diff in the mail between different RCs
Having different tags for different RC enables the following:
https://github.com/apache/calcite-avatica/compare/avatica-1.16.0-rc0..avatica-1.16.0-rc1
Vladimir
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
1. I did checked every tar/zip checksums before/after the release, would write id down in the mail next time ~
2. I would only release tar.gz soon ~
3. I did try the auto tag task from the Gradle prepareVote, but it fails every time and reports the authentication problem when creating the tag. So I create the tag with the commit hash manually, what’s the difference then ? It is still a tag
4. Would represent the diff in the mail between different RCs
5. I follow the instructions from the HOWTO https://www.apache.org/dev/release-signing and does not find any evidence that the WEB of TRUST is a requirement.
Best,
Danny Chan
在 2020年2月29日 +0800 PM4:51，Vladimir Sitnikov <si...@gmail.com>，写道：
> Danny, thanks for putting things together, however, I guess the vote mail
> requires clarifications before the votes can be cast :-/
>
> Danny>The hashes of the artifacts are as follows:
>
> dist.apache.org contains two archives, however, the vote mail lists just
> one of them.
> We had the very same case with 1.21.0 vote:
> https://lists.apache.org/thread.html/ebfdfc6d3ac0f81801d805dec014f10507ee9cd7af63cac2999aeb19%40%3Cdev.calcite.apache.org%3E
>
> Danny, can you please double-check all the release artifact checksums you
> are going to release via dist.apache.org?
>
>
> Danny>Release artifacts are signed with the following key:
> Danny>https://people.apache.org/keys/committer/danny0405.asc
>
> Is this key on the ASF web of trust?
> I'm not sure that is a hard requirement for release signing, but I guess
> historically we used the keys that were cross-signed by other
> PMC/committers.
>
> Danny>You can read the release notes here:
> Danny>
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>
> Did you create calcite-1.22.0 tag manually?
> I thought the build script should have created calcite-1.22.0-rc2,
> however, I do not see it.
>
> It looks sad to have the very same link /calcite/blob/calcite-1.22.0/site/
> in different mails :-/
> Then, it is not clear how to compare what has changed between the release
> candidates.
>
> The naming of calcite-1.22.0 tag is confusing: it can easily be confused
> with a true release tag (see
> https://lists.apache.org/thread.html/ra2bfc17c52d80250ed9848a1977ac23807282ab4c1c1b643625b36a8%40%3Cdev.calcite.apache.org%3E
> )
>
> Do we really need a release branch? Why can't we build candidates out of
> the master?
> I guess if we had calcite-1.22.0-rc0, -rc1, and so on tags right in the
> master branch, then everybody would see there's a release pending.
>
> Vladimir
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Julian Hyde <jh...@gmail.com>.
The advantage of a release branch is that we don’t need to force-push to master when we make a mistake.
Let’s continue to use a release branch.
Julian
> On Feb 29, 2020, at 07:25, Stamatis Zampetakis <za...@gmail.com> wrote:
>
> In the last release of avatica we didn't release two archives in the end
> (but only the .tar.gz) [1].
> Before that for a quite some time we were releasing only the tar.gz archive.
> I would suggest to do the same for this, and the following Calcite
> releases, until we reach some consensus around the problem of line endings
> [2, 3].
>
> Best,
> Stamatis
>
> [1]
> https://lists.apache.org/thread.html/18911eed28dc11f7c21679f244b66426822961406cf3fa4ab9834fbb%40%3Cdev.calcite.apache.org%3E
> [2]
> https://lists.apache.org/list.html?dev@calcite.apache.org:lte=1M:%5BVOTE%5D%20Release%20apache-avatica
> [3]
> https://lists.apache.org/thread.html/87f2973a1e78237cc001df360a837c1b170342aa6d84a2d2c482f867%40%3Cdev.calcite.apache.org%3E
>
>> On Sat, Feb 29, 2020 at 9:51 AM Vladimir Sitnikov <
>> sitnikov.vladimir@gmail.com> wrote:
>>
>> Danny, thanks for putting things together, however, I guess the vote mail
>> requires clarifications before the votes can be cast :-/
>>
>> Danny>The hashes of the artifacts are as follows:
>>
>> dist.apache.org contains two archives, however, the vote mail lists just
>> one of them.
>> We had the very same case with 1.21.0 vote:
>>
>> https://lists.apache.org/thread.html/ebfdfc6d3ac0f81801d805dec014f10507ee9cd7af63cac2999aeb19%40%3Cdev.calcite.apache.org%3E
>>
>> Danny, can you please double-check all the release artifact checksums you
>> are going to release via dist.apache.org?
>>
>>
>> Danny>Release artifacts are signed with the following key:
>> Danny>https://people.apache.org/keys/committer/danny0405.asc
>>
>> Is this key on the ASF web of trust?
>> I'm not sure that is a hard requirement for release signing, but I guess
>> historically we used the keys that were cross-signed by other
>> PMC/committers.
>>
>> Danny>You can read the release notes here:
>> Danny>
>> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>>
>> Did you create calcite-1.22.0 tag manually?
>> I thought the build script should have created calcite-1.22.0-rc2,
>> however, I do not see it.
>>
>> It looks sad to have the very same link /calcite/blob/calcite-1.22.0/site/
>> in different mails :-/
>> Then, it is not clear how to compare what has changed between the release
>> candidates.
>>
>> The naming of calcite-1.22.0 tag is confusing: it can easily be confused
>> with a true release tag (see
>>
>> https://lists.apache.org/thread.html/ra2bfc17c52d80250ed9848a1977ac23807282ab4c1c1b643625b36a8%40%3Cdev.calcite.apache.org%3E
>> )
>>
>> Do we really need a release branch? Why can't we build candidates out of
>> the master?
>> I guess if we had calcite-1.22.0-rc0, -rc1, and so on tags right in the
>> master branch, then everybody would see there's a release pending.
>>
>> Vladimir
>>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Danny Chan <yu...@gmail.com>.
I agree to only release tar.gz, thanks for the reminder ~
Stamatis Zampetakis <za...@gmail.com>于2020年2月29日 周六下午11:25写道：
> In the last release of avatica we didn't release two archives in the end
> (but only the .tar.gz) [1].
> Before that for a quite some time we were releasing only the tar.gz
> archive.
> I would suggest to do the same for this, and the following Calcite
> releases, until we reach some consensus around the problem of line endings
> [2, 3].
>
> Best,
> Stamatis
>
> [1]
>
> https://lists.apache.org/thread.html/18911eed28dc11f7c21679f244b66426822961406cf3fa4ab9834fbb%40%3Cdev.calcite.apache.org%3E
> [2]
>
> https://lists.apache.org/list.html?dev@calcite.apache.org:lte=1M:%5BVOTE%5D%20Release%20apache-avatica
> [3]
>
> https://lists.apache.org/thread.html/87f2973a1e78237cc001df360a837c1b170342aa6d84a2d2c482f867%40%3Cdev.calcite.apache.org%3E
>
> On Sat, Feb 29, 2020 at 9:51 AM Vladimir Sitnikov <
> sitnikov.vladimir@gmail.com> wrote:
>
> > Danny, thanks for putting things together, however, I guess the vote mail
> > requires clarifications before the votes can be cast :-/
> >
> > Danny>The hashes of the artifacts are as follows:
> >
> > dist.apache.org contains two archives, however, the vote mail lists just
> > one of them.
> > We had the very same case with 1.21.0 vote:
> >
> >
> https://lists.apache.org/thread.html/ebfdfc6d3ac0f81801d805dec014f10507ee9cd7af63cac2999aeb19%40%3Cdev.calcite.apache.org%3E
> >
> > Danny, can you please double-check all the release artifact checksums you
> > are going to release via dist.apache.org?
> >
> >
> > Danny>Release artifacts are signed with the following key:
> > Danny>https://people.apache.org/keys/committer/danny0405.asc
> >
> > Is this key on the ASF web of trust?
> > I'm not sure that is a hard requirement for release signing, but I guess
> > historically we used the keys that were cross-signed by other
> > PMC/committers.
> >
> > Danny>You can read the release notes here:
> > Danny>
> >
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
> >
> > Did you create calcite-1.22.0 tag manually?
> > I thought the build script should have created calcite-1.22.0-rc2,
> > however, I do not see it.
> >
> > It looks sad to have the very same link
> /calcite/blob/calcite-1.22.0/site/
> > in different mails :-/
> > Then, it is not clear how to compare what has changed between the release
> > candidates.
> >
> > The naming of calcite-1.22.0 tag is confusing: it can easily be confused
> > with a true release tag (see
> >
> >
> https://lists.apache.org/thread.html/ra2bfc17c52d80250ed9848a1977ac23807282ab4c1c1b643625b36a8%40%3Cdev.calcite.apache.org%3E
> > )
> >
> > Do we really need a release branch? Why can't we build candidates out of
> > the master?
> > I guess if we had calcite-1.22.0-rc0, -rc1, and so on tags right in the
> > master branch, then everybody would see there's a release pending.
> >
> > Vladimir
> >
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Stamatis Zampetakis <za...@gmail.com>.
In the last release of avatica we didn't release two archives in the end
(but only the .tar.gz) [1].
Before that for a quite some time we were releasing only the tar.gz archive.
I would suggest to do the same for this, and the following Calcite
releases, until we reach some consensus around the problem of line endings
[2, 3].
Best,
Stamatis
[1]
https://lists.apache.org/thread.html/18911eed28dc11f7c21679f244b66426822961406cf3fa4ab9834fbb%40%3Cdev.calcite.apache.org%3E
[2]
https://lists.apache.org/list.html?dev@calcite.apache.org:lte=1M:%5BVOTE%5D%20Release%20apache-avatica
[3]
https://lists.apache.org/thread.html/87f2973a1e78237cc001df360a837c1b170342aa6d84a2d2c482f867%40%3Cdev.calcite.apache.org%3E
On Sat, Feb 29, 2020 at 9:51 AM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> Danny, thanks for putting things together, however, I guess the vote mail
> requires clarifications before the votes can be cast :-/
>
> Danny>The hashes of the artifacts are as follows:
>
> dist.apache.org contains two archives, however, the vote mail lists just
> one of them.
> We had the very same case with 1.21.0 vote:
>
> https://lists.apache.org/thread.html/ebfdfc6d3ac0f81801d805dec014f10507ee9cd7af63cac2999aeb19%40%3Cdev.calcite.apache.org%3E
>
> Danny, can you please double-check all the release artifact checksums you
> are going to release via dist.apache.org?
>
>
> Danny>Release artifacts are signed with the following key:
> Danny>https://people.apache.org/keys/committer/danny0405.asc
>
> Is this key on the ASF web of trust?
> I'm not sure that is a hard requirement for release signing, but I guess
> historically we used the keys that were cross-signed by other
> PMC/committers.
>
> Danny>You can read the release notes here:
> Danny>
> https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
>
> Did you create calcite-1.22.0 tag manually?
> I thought the build script should have created calcite-1.22.0-rc2,
> however, I do not see it.
>
> It looks sad to have the very same link /calcite/blob/calcite-1.22.0/site/
> in different mails :-/
> Then, it is not clear how to compare what has changed between the release
> candidates.
>
> The naming of calcite-1.22.0 tag is confusing: it can easily be confused
> with a true release tag (see
>
> https://lists.apache.org/thread.html/ra2bfc17c52d80250ed9848a1977ac23807282ab4c1c1b643625b36a8%40%3Cdev.calcite.apache.org%3E
> )
>
> Do we really need a release branch? Why can't we build candidates out of
> the master?
> I guess if we had calcite-1.22.0-rc0, -rc1, and so on tags right in the
> master branch, then everybody would see there's a release pending.
>
> Vladimir
>
Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 2)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Danny, thanks for putting things together, however, I guess the vote mail
requires clarifications before the votes can be cast :-/
Danny>The hashes of the artifacts are as follows:
dist.apache.org contains two archives, however, the vote mail lists just
one of them.
We had the very same case with 1.21.0 vote:
https://lists.apache.org/thread.html/ebfdfc6d3ac0f81801d805dec014f10507ee9cd7af63cac2999aeb19%40%3Cdev.calcite.apache.org%3E
Danny, can you please double-check all the release artifact checksums you
are going to release via dist.apache.org?
Danny>Release artifacts are signed with the following key:
Danny>https://people.apache.org/keys/committer/danny0405.asc
Is this key on the ASF web of trust?
I'm not sure that is a hard requirement for release signing, but I guess
historically we used the keys that were cross-signed by other
PMC/committers.
Danny>You can read the release notes here:
Danny>
https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md
Did you create calcite-1.22.0 tag manually?
I thought the build script should have created calcite-1.22.0-rc2,
however, I do not see it.
It looks sad to have the very same link /calcite/blob/calcite-1.22.0/site/
in different mails :-/
Then, it is not clear how to compare what has changed between the release
candidates.
The naming of calcite-1.22.0 tag is confusing: it can easily be confused
with a true release tag (see
https://lists.apache.org/thread.html/ra2bfc17c52d80250ed9848a1977ac23807282ab4c1c1b643625b36a8%40%3Cdev.calcite.apache.org%3E
)
Do we really need a release branch? Why can't we build candidates out of
the master?
I guess if we had calcite-1.22.0-rc0, -rc1, and so on tags right in the
master branch, then everybody would see there's a release pending.
Vladimir