[jira] [Comment Edited] (HBASE-18641) Include block content verification logic used in lruCache in bucketCache

["Biju Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157490#comment-16157490 ] 

Biju Nair edited comment on HBASE-18641 at 9/7/17 7:31 PM:
-----------------------------------------------------------

bq. Why not in other case?

With LRU and BucketCache used strictly as L1&L1, the comparison is already done in the LRU cache. This patch preserves the current behavior.

bq.  Caching an already ....

Will provide an updated patch


was (Author: gsbiju):
bq. Why not in other case?

With LRU and BucketCache used strictly as L1&L1, the comparison is already done in the LRU cache. This patch change preserves the current behavior.

bq.  Caching an already ....

Will provide an updated patch

> Include block content verification logic used in lruCache in bucketCache
> ------------------------------------------------------------------------
>
>                 Key: HBASE-18641
>                 URL: https://issues.apache.org/jira/browse/HBASE-18641
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Biju Nair
>            Assignee: Biju Nair
>         Attachments: HBASE-18641.PATCH, HBASE-18641-WIP.PATCH
>
>
> With off-heap/bucketCache being used to cache data blocks without going through on-heap cache, the logic used in lruCache to check the content of already cached block need to be included in bucketCache. Please see this [discussion|https://mail-archives.apache.org/mod_mbox/hbase-dev/201708.mbox/%3cCAO40JLCnXLw3=0bbUaXdDx=w2fkLLJefVgJ6-UVJ_2JhfvOz+Q@mail.gmail.com%3e] for details. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)