You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/11 07:07:56 UTC
[GitHub] [inlong] Oneal65 opened a new pull request, #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Oneal65 opened a new pull request, #5483:
URL: https://github.com/apache/inlong/pull/5483
- Fixes #5210
### Motivation
Add reporting metrics for Elasticsearch 7 connector and audit SDK
### Modifications
Elasticsearch 7 connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5483:
URL: https://github.com/apache/inlong/pull/5483#discussion_r943170425
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/RowElasticsearchSinkFunction.java:
##########
@@ -119,6 +148,7 @@ private void processUpsert(RowData row, RequestIndexer indexer) {
if (sinkMetricData.getNumBytesOut() != null) {
sinkMetricData.getNumBytesOut().inc(document.length);
}
+ outputMetricForAudit(document.length);
Review Comment:
@thesumery should the rowData of DELETE mode be counted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] thesumery commented on a diff in pull request #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Posted by GitBox <gi...@apache.org>.
thesumery commented on code in PR #5483:
URL: https://github.com/apache/inlong/pull/5483#discussion_r943167353
##########
inlong-sort/sort-connectors/elasticsearch-base/src/main/java/org/apache/inlong/sort/elasticsearch/table/RowElasticsearchSinkFunction.java:
##########
@@ -119,6 +148,7 @@ private void processUpsert(RowData row, RequestIndexer indexer) {
if (sinkMetricData.getNumBytesOut() != null) {
sinkMetricData.getNumBytesOut().inc(document.length);
}
+ outputMetricForAudit(document.length);
Review Comment:
Here only output +I/+U data？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5483:
URL: https://github.com/apache/inlong/pull/5483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5483:
URL: https://github.com/apache/inlong/pull/5483#discussion_r943169727
##########
inlong-sort/sort-connectors/elasticsearch-base/pom.xml:
##########
@@ -152,6 +152,11 @@
<artifactId>log4j-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>audit-sdk</artifactId>
+ <version>1.3.0-SNAPSHOT</version>
Review Comment:
It is better to use ${xxx.version} to replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Oneal65 commented on a diff in pull request #5483: [INLONG-5210][Sort] Add reporting metrics for Elasticsearch 7 connector and audit SDK
Posted by GitBox <gi...@apache.org>.
Oneal65 commented on code in PR #5483:
URL: https://github.com/apache/inlong/pull/5483#discussion_r943171379
##########
inlong-sort/sort-connectors/elasticsearch-base/pom.xml:
##########
@@ -152,6 +152,11 @@
<artifactId>log4j-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.inlong</groupId>
+ <artifactId>audit-sdk</artifactId>
+ <version>1.3.0-SNAPSHOT</version>
Review Comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org