You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Mark Lundquist (JIRA)" <ji...@apache.org> on 2006/11/30 04:41:21 UTC

[jira] Created: (COCOON-1959) o.a.c.environment.Request'setParameter()

o.a.c.environment.Request'setParameter()
----------------------------------------

                 Key: COCOON-1959
                 URL: http://issues.apache.org/jira/browse/COCOON-1959
             Project: Cocoon
          Issue Type: Improvement
          Components: * Cocoon Core
    Affects Versions: 2.2-dev (Current SVN), 2.1.10-dev (current SVN)
            Reporter: Mark Lundquist
            Priority: Minor


I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.

Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).

If I don't hear any -1, I'll write a patch to do this.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (COCOON-1959) o.a.c.environment.Request'setParameter()

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473006 ] 

Carsten Ziegeler commented on COCOON-1959:
------------------------------------------

Ok, I see. Now, we could extend the sitemap source to allow adding, removing or changing of parameters. The source resolver in Cocoon has a method which gets three parameters where the third one is a source specific "parameters" object. So we could add information there to change the parameters. This would be a clean implementation as this changes only the source implementation and does not require to change o.a.c.environment classes.

So, if you still think that you need this, perhaps you could come up with a patch for this?
Or if you don't need this anymore, perhaps close this bug?

Thanks

> o.a.c.environment.Request'setParameter()
> ----------------------------------------
>
>                 Key: COCOON-1959
>                 URL: https://issues.apache.org/jira/browse/COCOON-1959
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.2-dev (Current SVN)
>            Reporter: Mark Lundquist
>         Assigned To: Carsten Ziegeler
>            Priority: Minor
>
> I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.
> Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).
> If I don't hear any -1, I'll write a patch to do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (COCOON-1959) o.a.c.environment.Request'setParameter()

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed COCOON-1959.
------------------------------------

    Resolution: Won't Fix

This one has been open for a long time, so I think it's ok to close this know

> o.a.c.environment.Request'setParameter()
> ----------------------------------------
>
>                 Key: COCOON-1959
>                 URL: https://issues.apache.org/jira/browse/COCOON-1959
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.2
>            Reporter: Mark Lundquist
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>
> I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.
> Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).
> If I don't hear any -1, I'll write a patch to do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-1959) o.a.c.environment.Request'setParameter()

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472626 ] 

Carsten Ziegeler commented on COCOON-1959:
------------------------------------------

Oh, we're changing everything and this class is going away....

Seriously, what exactly do you want to achieve?

> o.a.c.environment.Request'setParameter()
> ----------------------------------------
>
>                 Key: COCOON-1959
>                 URL: https://issues.apache.org/jira/browse/COCOON-1959
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.2-dev (Current SVN)
>            Reporter: Mark Lundquist
>            Priority: Minor
>
> I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.
> Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).
> If I don't hear any -1, I'll write a patch to do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-1959) o.a.c.environment.Request'setParameter()

Posted by "Mark Lundquist (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/COCOON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472942 ] 

Mark Lundquist commented on COCOON-1959:
----------------------------------------

The idea is to be able to add a new parameter to the current request (and maybe also change existing ones, I guess), before forwarding to another Cocoon pipeline.  Sorry, I don't recall exactly what my use case was for this.  Most likely, the workaround would have been to bung a query-string onto the request URI, which I would have found bletcherous...


> o.a.c.environment.Request'setParameter()
> ----------------------------------------
>
>                 Key: COCOON-1959
>                 URL: https://issues.apache.org/jira/browse/COCOON-1959
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.2-dev (Current SVN)
>            Reporter: Mark Lundquist
>         Assigned To: Carsten Ziegeler
>            Priority: Minor
>
> I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.
> Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).
> If I don't hear any -1, I'll write a patch to do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (COCOON-1959) o.a.c.environment.Request'setParameter()

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler reassigned COCOON-1959:
----------------------------------------

    Assignee: Carsten Ziegeler

> o.a.c.environment.Request'setParameter()
> ----------------------------------------
>
>                 Key: COCOON-1959
>                 URL: https://issues.apache.org/jira/browse/COCOON-1959
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: * Cocoon Core
>    Affects Versions: 2.1.10, 2.2-dev (Current SVN)
>            Reporter: Mark Lundquist
>         Assigned To: Carsten Ziegeler
>            Priority: Minor
>
> I would like to add a setParameter() method to o.a.c.environment.Request.  I think this would be useful for setting up internal forwards.
> Please let me know if (a) this isn't going to work the way I want it to, or (b) there's some other reason not to do this, e.g. "oh, we're changing everything and that class is going away" :-).
> If I don't hear any -1, I'll write a patch to do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.