You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/09/16 14:24:37 UTC
[PR] [studio] fix: preserve alert state for non-semantic rule changes [rocketmq-dashboard]
zmuxuny opened a new pull request, #4457:
URL: https://github.com/apache/rocketmq-dashboard/pull/4457
### Which Issue(s) This PR Fixes
Fixes #4326
### Brief Description
Alert rule updates and enable/disable operations previously deleted stored evaluation state unconditionally. Presentation or delivery-only changes could therefore erase a FIRING/PENDING episode and its ACK state.
This change aligns state invalidation with the existing `AlertRuleSemanticFingerprint`: semantic evaluation changes reset state, while renaming, severity/channel changes, and single or bulk enable/disable operations preserve it. Rule deletion still removes stored state.
### How Did You Test This Change?
Amazon Corretto JDK 21.0.12 + Apache Maven 3.9.16:
`mvn -B -ntp -Dtest=AlertServiceTest,AlertRuleSemanticFingerprintTest test`
Result: **87 tests, 0 failures, 0 errors, 0 skipped; BUILD SUCCESS.** Checkstyle reported **0 violations**. `git diff --check` is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): preserve state without orphaning disabled rules [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #4457:
URL: https://github.com/apache/rocketmq-dashboard/pull/4457#issuecomment-5794421048
Hi @lizhimins, thank you for the detailed review. I pushed `9380d072` and updated the PR description with the disable/enable/edit/delete state policy and its regression coverage. Could you please take another look at the revised PR when convenient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): preserve state without orphaning disabled rules [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #4457:
URL: https://github.com/apache/rocketmq-dashboard/pull/4457#issuecomment-5771213294
Addressed the blocking lifecycle items in `9380d072` on `rocketmq-studio@4c697f0`.
The explicit policy is now disable -> purge, enable -> preserve, semantic edit -> purge, and presentation-only edit of an enabled rule -> preserve. Both toggle overloads, both bulk paths and both edit entrypoints are covered. Delete still purges; disabling does not emit a synthetic recovery.
A new stateful runtime regression first observes FIRING plus reminder timestamps and then requires the disabled rule's runtime view to be empty. All six disable variants failed against the previous implementation (20 lifecycle cases, 6 failures); the revised lifecycle suite is 20/20. The combined lifecycle/service/fingerprint/native-processor suite is 130/130, Checkstyle 0 and package succeeds. The PR body now explicitly explains the enable-direction contract change and the retained disable/delete assertions.
The optional duplicate lookup optimization is left separate to keep this revision focused. No full external-datasource integration run is claimed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): preserve state without orphaning disabled rules [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4457:
URL: https://github.com/apache/rocketmq-dashboard/pull/4457#issuecomment-5975210557
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): preserve state without orphaning disabled rules [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #4457:
URL: https://github.com/apache/rocketmq-dashboard/pull/4457#issuecomment-5845515846
For tracking: linked issue #4326 was automatically closed by the stale workflow on September 26 while this PR remains open. Revision `9380d072` contains the response to the September 21 review, including the explicit disable/enable/edit/delete state policy and the disabled-rule runtime regression described above.
I cannot reopen #4326 from my account. Could a maintainer reopen it if the original report should remain linked until this PR is resolved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): preserve state without orphaning disabled rules [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4457: fix(alert): preserve state without orphaning disabled rules
URL: https://github.com/apache/rocketmq-dashboard/pull/4457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org