You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/02 07:15:13 UTC

[GitHub] [iotdb] Alima777 commented on a change in pull request #3303: [To rel/0.11] Overlapped data should be consumed first

Alima777 commented on a change in pull request #3303:
URL: https://github.com/apache/iotdb/pull/3303#discussion_r643713352



##########
File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBOverlappedPageIT.java
##########
@@ -89,17 +108,51 @@ public void selectOverlappedPageTest() {
     try (Connection connection = DriverManager
             .getConnection(Config.IOTDB_URL_PREFIX + "127.0.0.1:6667/", "root", "root");
          Statement statement = connection.createStatement()) {
+      insertData();
+
       String sql = "select s0 from root.vehicle.d0 where time >= 1 and time <= 110 AND root.vehicle.d0.s0 > 110";
       ResultSet resultSet = statement.executeQuery(sql);
       int cnt = 0;
-      try {
+      while (resultSet.next()) {
+        String ans = resultSet.getString(TIMESTAMP_STR) + "," + resultSet.getString("root.vehicle.d0.s0");
+        Assert.assertEquals(res[cnt], ans);
+        cnt++;
+      }
+    } catch (Exception e) {
+      e.printStackTrace();
+      fail(e.getMessage());

Review comment:
       Fixed. Define it as a local variable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org