[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4326: [TE] Clean up and inject ThirdEye Credentials into SecurityContext

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4326: [TE] Clean up and inject ThirdEye Credentials into SecurityContext
URL: https://github.com/apache/incubator-pinot/pull/4326#discussion_r294445498
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/auth/ThirdEyeCredentials.java
 ##########
 @@ -22,9 +22,18 @@
 import java.util.Objects;
 
 
-public class Credentials {
+public class ThirdEyeCredentials {
   String principal;
   String password;
+  String token;
 
 Review comment:
   Is it mainly for service account?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org