You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/02/18 13:37:22 UTC

[GitHub] [unomi] anatol-sialitski opened a new pull request #252: UNOMI-350 Implement CDP_Source definition & retrieval

anatol-sialitski opened a new pull request #252:
URL: https://github.com/apache/unomi/pull/252


   In scope this PR was implemented the following things:
   - Added SourceItem object and related services with it
   - `getSources` query; `createOrUpdateSource` and `deleteSource`  mutations of the GraphQL API
   - Added a new system property UNOMI_SHOULD_BE_CHECKED_EVENT_SOURCE_ID
   - Added IT tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] anatol-sialitski commented on a change in pull request #252: UNOMI-350 Implement CDP_Source definition & retrieval

Posted by GitBox <gi...@apache.org>.
anatol-sialitski commented on a change in pull request #252:
URL: https://github.com/apache/unomi/pull/252#discussion_r580180171



##########
File path: api/src/main/java/org/apache/unomi/api/Event.java
##########
@@ -369,10 +372,12 @@ public void setProperties(Map<String, Object> properties) {
     /**
      * @return the scope
      */
+    @Deprecated

Review comment:
       According to the [ticket](https://issues.apache.org/jira/browse/UNOMI-350)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Taybou commented on a change in pull request #252: UNOMI-350 Implement CDP_Source definition & retrieval

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #252:
URL: https://github.com/apache/unomi/pull/252#discussion_r580225659



##########
File path: api/src/main/java/org/apache/unomi/api/Event.java
##########
@@ -369,10 +372,12 @@ public void setProperties(Map<String, Object> properties) {
     /**
      * @return the scope
      */
+    @Deprecated

Review comment:
       Great, thank you




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber merged pull request #252: UNOMI-350 Implement CDP_Source definition & retrieval

Posted by GitBox <gi...@apache.org>.
sergehuber merged pull request #252:
URL: https://github.com/apache/unomi/pull/252


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] Taybou commented on a change in pull request #252: UNOMI-350 Implement CDP_Source definition & retrieval

Posted by GitBox <gi...@apache.org>.
Taybou commented on a change in pull request #252:
URL: https://github.com/apache/unomi/pull/252#discussion_r580148831



##########
File path: api/src/main/java/org/apache/unomi/api/Event.java
##########
@@ -369,10 +372,12 @@ public void setProperties(Map<String, Object> properties) {
     /**
      * @return the scope
      */
+    @Deprecated

Review comment:
       why **@Deprecated** the scope of the event?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org