You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/06/18 03:06:08 UTC
Re: svn commit: r31761 - branches/issue-2843-dev/subversion/libsvn_wc
firemeteor@tigris.org writes:
> Log:
> On the issue-2843-dev branch.
>
> * subversion/libsvn_wc/crop.c
> (crop_children): Shrow an exception on un-expected entry kind.
Just following up to let you know I reviewed it -- looks good, and
thanks for remembering to call svn_path_local_style() :-).
-Karl
> --- branches/issue-2843-dev/subversion/libsvn_wc/crop.c Mon Jun 16 09:01:36 2008 (r31760)
> +++ branches/issue-2843-dev/subversion/libsvn_wc/crop.c Tue Jun 17 05:21:40 2008 (r31761)
> @@ -26,6 +26,8 @@
> #include "svn_path.h"
> #include "entries.h"
>
> +#include "svn_private_config.h"
> +
> /* Evaluate EXPR. If it returns an error, return that error, unless
> the error's code is SVN_ERR_WC_LEFT_LOCAL_MOD, in which case clear
> the error and do not return. */
> @@ -163,7 +165,9 @@ crop_children(svn_wc_adm_access_t *adm_a
> }
> else
> {
> - /* TODO(2843): What about svn_node_none & svn_node_unkown? */
> + return svn_error_createf
> + (SVN_ERR_NODE_UNKNOWN_KIND, NULL, _("Unknown entry kind for '%s'"),
> + svn_path_local_style(this_path, pool));
> }
>
> if (notify_func)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r31761 -
branches/issue-2843-dev/subversion/libsvn_wc
Posted by "Rui, Guo" <ti...@mail.ustc.edu.cn>.
On Tue, Jun 17, 2008 at 11:06:08PM -0400, Karl Fogel wrote:
> firemeteor@tigris.org writes:
> > Log:
> > On the issue-2843-dev branch.
> >
> > * subversion/libsvn_wc/crop.c
> > (crop_children): Shrow an exception on un-expected entry kind.
>
> Just following up to let you know I reviewed it -- looks good, and
> thanks for remembering to call svn_path_local_style() :-).
>
> -Karl
Hehe. I just picked it up from somewhere that also check for entry kind.
Rui
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org