You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dave Brosius (Created) (JIRA)" <ji...@apache.org> on 2012/01/30 22:01:10 UTC
[jira] [Created] (CASSANDRA-3814) [patch] add assertion message for
deserializing columns assertion failure
[patch] add assertion message for deserializing columns assertion failure
-------------------------------------------------------------------------
Key: CASSANDRA-3814
URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
Project: Cassandra
Issue Type: Improvement
Components: Core
Reporter: Dave Brosius
Priority: Trivial
use was doing
create column family report_by_account_content with comparator=UTF8Type;
update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
assert was generated but not represented to client. adding message:
// column name format <cf>:<column name>:<attribute name>
String[] components = columns.getComparator().getString(column.name()).split(":");
assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3814) [patch] add
assertion message for deserializing columns assertion failure
Posted by "Dave Brosius (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196577#comment-13196577 ]
Dave Brosius edited comment on CASSANDRA-3814 at 1/31/12 4:43 AM:
------------------------------------------------------------------
as for being a dup, i'm assuming the error i got was the same as the user, but he didn't debug the server side so i can't say for sure.
And yes, i wasn't suggesting this as 'the fix' but if its going to throw asserts, would be nice to have information as well.
was (Author: dbrosius@apache.org):
as for being a dup, i'm assuming the error i got was the same as the user, but he didn't debug the server side so i can't say for sure.
> [patch] add assertion message for deserializing columns assertion failure
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-3814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: assert_msg.diff
>
>
> use was doing
> create column family report_by_account_content with comparator=UTF8Type;
> update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
> assert was generated but not represented to client. adding message:
> // column name format <cf>:<column name>:<attribute name>
> String[] components = columns.getComparator().getString(column.name()).split(":");
> assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3814) [patch] add assertion message
for deserializing columns assertion failure
Posted by "Dave Brosius (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196577#comment-13196577 ]
Dave Brosius commented on CASSANDRA-3814:
-----------------------------------------
as for being a dup, i'm assuming the error i got was the same as the user, but he didn't debug the server side so i can't say for sure.
> [patch] add assertion message for deserializing columns assertion failure
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-3814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: assert_msg.diff
>
>
> use was doing
> create column family report_by_account_content with comparator=UTF8Type;
> update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
> assert was generated but not represented to client. adding message:
> // column name format <cf>:<column name>:<attribute name>
> String[] components = columns.getComparator().getString(column.name()).split(":");
> assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3814) [patch] add assertion message
for deserializing columns assertion failure
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196487#comment-13196487 ]
Jonathan Ellis commented on CASSANDRA-3814:
-------------------------------------------
Hmm.
- Asserts are "shouldn't happen" territory (we run with them enabled by default but it's totally kosher to disable), we should check something a client gives us for sanity somewhere else, often ThriftValidation
- This assert doesn't exist at all in 1.0, which is what CASSANDRA-3813 is reported against
(So we can close 3813 as duplicate of this, right?)
> [patch] add assertion message for deserializing columns assertion failure
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-3814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: assert_msg.diff
>
>
> use was doing
> create column family report_by_account_content with comparator=UTF8Type;
> update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
> assert was generated but not represented to client. adding message:
> // column name format <cf>:<column name>:<attribute name>
> String[] components = columns.getComparator().getString(column.name()).split(":");
> assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3814) [patch] add assertion message
for deserializing columns assertion failure
Posted by "Dave Brosius (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196473#comment-13196473 ]
Dave Brosius commented on CASSANDRA-3814:
-----------------------------------------
ah didn't no user would post bug 3813
> [patch] add assertion message for deserializing columns assertion failure
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-3814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: assert_msg.diff
>
>
> use was doing
> create column family report_by_account_content with comparator=UTF8Type;
> update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
> assert was generated but not represented to client. adding message:
> // column name format <cf>:<column name>:<attribute name>
> String[] components = columns.getComparator().getString(column.name()).split(":");
> assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3814) [patch] add assertion message for
deserializing columns assertion failure
Posted by "Dave Brosius (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated CASSANDRA-3814:
------------------------------------
Attachment: assert_msg.diff
> [patch] add assertion message for deserializing columns assertion failure
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-3814
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3814
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: assert_msg.diff
>
>
> use was doing
> create column family report_by_account_content with comparator=UTF8Type;
> update column family report_by_account_content with comparator=UTF8Type and column_metadata = [{ column_name:'meta:account-id', validation_class:UTF8Type,index_type:KEYS},{ column_name:'meta:filter-hash', validation_class:UTF8Type,index_type:KEYS}];
> assert was generated but not represented to client. adding message:
> // column name format <cf>:<column name>:<attribute name>
> String[] components = columns.getComparator().getString(column.name()).split(":");
> assert components.length == 3 : "Number of Comparator components not 3: " + Arrays.toString(components);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira