You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/03 08:34:38 UTC
Re: Review Request 61210: Renamed constants for CLI tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61210/
-----------------------------------------------------------
(Updated Sept. 3, 2017, 8:34 a.m.)
Review request for mesos and Kevin Klues.
Bugs: MESOS-7840
https://issues.apache.org/jira/browse/MESOS-7840
Repository: mesos
Description (updated)
-------
These constants are now prefixed by 'TEST' instead of 'DEFAULT'.
Diffs (updated)
-----
src/python/cli_new/lib/cli/tests/base.py 1101aef79d0d99c0c6e69296adf622891897e5bc
src/python/cli_new/lib/cli/tests/constants.py 5d45d94c9274cb9c16820da2d3314265345df1c6
Diff: https://reviews.apache.org/r/61210/diff/2/
Changes: https://reviews.apache.org/r/61210/diff/1-2/
Testing
-------
```
$ ./bootstrap
$ source activate
$ mesos-cli-tests
```
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 61210: Renamed constants for CLI tests.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61210/#review185983
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Sept. 3, 2017, 8:34 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61210/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 8:34 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These constants are now prefixed by 'TEST' instead of 'DEFAULT'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/base.py 1101aef79d0d99c0c6e69296adf622891897e5bc
> src/python/cli_new/lib/cli/tests/constants.py 5d45d94c9274cb9c16820da2d3314265345df1c6
>
>
> Diff: https://reviews.apache.org/r/61210/diff/2/
>
>
> Testing
> -------
>
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 61210: Renamed constants for CLI tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61210/#review184469
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61210]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 3, 2017, 8:34 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61210/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2017, 8:34 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7840
> https://issues.apache.org/jira/browse/MESOS-7840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These constants are now prefixed by 'TEST' instead of 'DEFAULT'.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/tests/base.py 1101aef79d0d99c0c6e69296adf622891897e5bc
> src/python/cli_new/lib/cli/tests/constants.py 5d45d94c9274cb9c16820da2d3314265345df1c6
>
>
> Diff: https://reviews.apache.org/r/61210/diff/2/
>
>
> Testing
> -------
>
> ```
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
> ```
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>