[GitHub] [apisix] spacewander commented on a change in pull request #4347: perf: use events optimize nacos service discovery

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #4347:
URL: https://github.com/apache/apisix/pull/4347#discussion_r643611910



##########
File path: docs/en/latest/discovery/nacos.md
##########
@@ -27,7 +27,7 @@ This is experimental discovery module for Nacos.
 
 The performance of this module needs to be improved:
 
-1. avoid synchroning configuration in each workers. You can refer the implementation in `consul_kv.lua`.
+1. ~~avoid synchroning configuration in each workers. You can refer the implementation in `consul_kv.lua`.~~

Review comment:
       We can directly remove it.

##########
File path: apisix/discovery/nacos.lua
##########
@@ -80,8 +83,16 @@ local schema = {
 }
 
 
-local _M = {}
+local _M = {
+    version = 0.2,

Review comment:
       We don't need to add the version number.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org