You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "NicolaIsotta (via GitHub)" <gi...@apache.org> on 2023/01/23 13:52:52 UTC
[GitHub] [netbeans] NicolaIsotta opened a new issue, #5351: CSS: bad handling of colons in class names
NicolaIsotta opened a new issue, #5351:
URL: https://github.com/apache/netbeans/issues/5351
### Apache NetBeans version
Apache NetBeans 16
### What happened
Netbeans does not handle css classes correctly if they contain colons (maybe other special chars too). I discovered this while using [primeflex](https://github.com/primefaces/primeflex).
In particular:
- css class suggestion should not contain the escape char before the colon
- there's a warning "Class xxx not found" if the class contains a colon
### How to reproduce
Include primeflex css in your webpage ( https://unpkg.com/primeflex@3.3.0/primeflex.css ).
### Did this work correctly in an earlier version?
No / Don't know
### Operating System
Windows 10 version 10.0 running on amd64; Cp1252; it_IT (nb)
### JDK
11.0.13; Java HotSpot(TM) 64-Bit Server VM 11.0.13+10-LTS-370
### Apache NetBeans packaging
Apache NetBeans binary zip
### Anything else
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] NicolaIsotta commented on issue #5351: CSS: bad handling of colons in class names
Posted by "NicolaIsotta (via GitHub)" <gi...@apache.org>.
NicolaIsotta commented on issue #5351:
URL: https://github.com/apache/netbeans/issues/5351#issuecomment-1470428252
I found out why, there are 3 possible cases:
- css in the project folder and link targets the local css: everything (suggestion and check) works
- css in the project folder, link targets remote css: suggestions work but greyed out, check does not work
- no local css, link targets remote css: nothing works (even though the css appear in the "Remote Files" node)
but I do not think the remote css problem has something to do with this PR. Might be another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #5351: CSS: bad handling of colons in class names
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed issue #5351: CSS: bad handling of colons in class names
URL: https://github.com/apache/netbeans/issues/5351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] NicolaIsotta commented on issue #5351: CSS: bad handling of colons in class names
Posted by "NicolaIsotta (via GitHub)" <gi...@apache.org>.
NicolaIsotta commented on issue #5351:
URL: https://github.com/apache/netbeans/issues/5351#issuecomment-1469598451
Hi @matthiasblaesing , I've tested the nightly build.
Suggestions work:
Bu there's still the class not found warning:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #5351: CSS: bad handling of colons in class names
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #5351:
URL: https://github.com/apache/netbeans/issues/5351#issuecomment-1470325085
@NicolaIsotta thank you for testing. However I could not reproduce your finding. In drying to reproduce I did this:
1. I downloaded the nightly build referenced in my original comment
2. I started that version with a clean userdir like this: `netbeans/bin/netbeans --userdir userdir --cachedir cachedir`
3. I created a new project using the "HTML5/JS Application" template
4. I downloaded the primeflex css file into the `public_html`
5. The `index.html` was modified to read:
```html
<!DOCTYPE html>
<!--
Click nbfs://nbhost/SystemFileSystem/Templates/Licenses/license-default.txt to change this license
Click nbfs://nbhost/SystemFileSystem/Templates/Other/html.html to edit this template
-->
<html>
<head>
<title>TODO supply a title</title>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link href="primeflex.css" rel="stylesheet" />
</head>
<body>
<div class="sm:align-content-between">TODO write content</div>
</body>
</html>
```
With that setup I see no errors:
My suspicion is, that the CSS file can't be directly resolved via the `link` tag. See this screenshot:
The first entries (dark-green) come from `primeflex.css` directly referenced (code is the same as shown above). The light-gray entry `.sm:align-content-dummy` comes from a new file I created in the project, but did not reference. Using this class would be flagged.
Could you provide the full project you used to test? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #5351: CSS: bad handling of colons in class names
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #5351:
URL: https://github.com/apache/netbeans/issues/5351#issuecomment-1467541630
@NicolaIsotta could you please test this nightly build:
https://github.com/apache/netbeans/suites/11531466195/artifacts/596675121
It can be accessed from the latest checks run:
https://github.com/apache/netbeans/actions/runs/4408188233
The PR description:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #5351: CSS: bad handling of colons in class names
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #5351:
URL: https://github.com/apache/netbeans/issues/5351#issuecomment-1470632892
@NicolaIsotta thanks for the update. Yes the remote CSS issue is a different one (I think I already saw a corresponding issue). I plan to let this wait until the weekend and if noone intervenes, I'll merge then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists