You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "GC-20-20 (via GitHub)" <gi...@apache.org> on 2024/04/08 11:45:25 UTC
[PR] examples/pipe:removes useless data from test cases [nuttx-apps]
GC-20-20 opened a new pull request, #2351:
URL: https://github.com/apache/nuttx-apps/pull/2351
## Summary
A file was created during the test, and it was not deleted when it was used up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] examples/pipe:removes useless data from test cases [nuttx-apps]
Posted by "GC-20-20 (via GitHub)" <gi...@apache.org>.
GC-20-20 commented on code in PR #2351:
URL: https://github.com/apache/nuttx-apps/pull/2351#discussion_r1558786349
##########
examples/pipe/pipe_main.c:
##########
@@ -157,6 +157,11 @@ int main(int argc, FAR char *argv[])
return 6;
}
+ ret = remove(FIFO_PATH1);
+ if (ret != 0)
+ {
+ fprintf(stderr, "pipe_main: remove failed with errno=%d\n", errno);
+ }
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] examples/pipe:removes useless data from test cases [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #2351:
URL: https://github.com/apache/nuttx-apps/pull/2351#discussion_r1555814827
##########
examples/pipe/pipe_main.c:
##########
@@ -157,6 +157,11 @@ int main(int argc, FAR char *argv[])
return 6;
}
+ ret = remove(FIFO_PATH1);
+ if (ret != 0)
+ {
+ fprintf(stderr, "pipe_main: remove failed with errno=%d\n", errno);
+ }
Review Comment:
fix the warning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] examples/pipe:removes useless data from test cases [nuttx-apps]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #2351:
URL: https://github.com/apache/nuttx-apps/pull/2351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org