You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by arunma <gi...@git.apache.org> on 2017/08/16 15:17:18 UTC
[GitHub] nifi pull request #2093: NIFI-4062 Provide an option to disable DTD validati...
GitHub user arunma opened a pull request:
https://github.com/apache/nifi/pull/2093
NIFI-4062 Provide an option to disable DTD validation for EvaluateXPa…
…th and EvaluateXQuery
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunma/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2093
----
commit d2032da711a3ee14ddc499baccefe486072b6c51
Author: Arun Manivannan <ar...@arunma.com>
Date: 2017-08-12T05:41:18Z
NIFI-4062 Provide an option to disable DTD validation for EvaluateXPath and EvaluateXQuery
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2093: NIFI-4062 Provide an option to disable DTD validation for ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2093
@arunma Thanks for the updates. I'm going to build it locally once again just in case.
When you rebase or squash the commits, then you need to push to your branch forcefully, for example:
```
# To rebase
git checkout master
git pull upstream master
git checkout <branch-for-pr>
git rebase master
# To squash (the HEAD~3 indicates how many recent commits you want to rebase)
git rebase -i HEAD~3
# After rebase (with latest master, or squash commits), push updated commit to the existing PR with -f option
git push -f origin <branch-for-pr>
```
By pushing updates to the existing branch, you don't need to close/open new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2093: NIFI-4062 Provide an option to disable DTD validation for ...
Posted by arunma <gi...@git.apache.org>.
Github user arunma commented on the issue:
https://github.com/apache/nifi/pull/2093
@ijokarumawak Thanks for all the patience and very useful review. I learnt quite a lot.
Is there a way to prevent the PR from closing itself automatically when I tried to reset my master with the latest of the upstream? I feel bad for opening up different PRs like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2093: NIFI-4062 Provide an option to disable DTD validation for ...
Posted by arunma <gi...@git.apache.org>.
Github user arunma commented on the issue:
https://github.com/apache/nifi/pull/2093
Thanks a ton for the merge and the git tip, @ijokarumawak!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #2093: NIFI-4062 Provide an option to disable DTD validation for ...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2093
@arunma Local contrib-check passed successfully. All review comments are addressed. LGTM, +1, merging to master. Thanks again for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #2093: NIFI-4062 Provide an option to disable DTD validati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---