You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (Created) (JIRA)" <ji...@apache.org> on 2011/10/11 17:13:12 UTC

[jira] [Created] (HTTPCLIENT-1136) BasicClientConnectionManager.releaseConnection accesses poolEntry using non-standard lock

BasicClientConnectionManager.releaseConnection accesses poolEntry using non-standard lock
-----------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-1136
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1136
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: HttpClient
            Reporter: Sebb


According to the annotation, poolEntry is @GuardedBy("this").

However, in at least one place, it is accessed without holding a lock on this: 

BasicClientConnectionManager.releaseConnection synchronizes on managedConn, and then accesses poolEntry without synchronising on this.

[Synch. only works if all parties use the same lock.]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] [Resolved] (HTTPCLIENT-1136) BasicClientConnectionManager.releaseConnection accesses poolEntry using non-standard lock

Posted by "Oleg Kalnichevski (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1136.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.2 Alpha1

Fixed in SVN trunk.

Oleg
                
> BasicClientConnectionManager.releaseConnection accesses poolEntry using non-standard lock
> -----------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1136
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1136
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>            Reporter: Sebb
>             Fix For: 4.2 Alpha1
>
>
> According to the annotation, poolEntry is @GuardedBy("this").
> However, in at least one place, it is accessed without holding a lock on this: 
> BasicClientConnectionManager.releaseConnection synchronizes on managedConn, and then accesses poolEntry without synchronising on this.
> [Synch. only works if all parties use the same lock.]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org