[GitHub] [zookeeper] eolivelli commented on a change in pull request #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #846: ZOOKEEPER-3302 ZooKeeper C client does not compile on Fedora 29
URL: https://github.com/apache/zookeeper/pull/846#discussion_r265340602
 
 

 ##########
 File path: zookeeper-client/zookeeper-client-c/src/cli.c
 ##########
 @@ -678,15 +678,15 @@ int main(int argc, char **argv) {
     }
     if (argc > 2) {
       if(strncmp("cmd:",argv[2],4)==0){
 
 Review comment:
   Sure.
   Honestly I don't know how tests are implement in C projects.
   I will take a look at existing tests and try to come back with a test.
   
   Is there any way to run a single C test?
   
   Btw I will check existing docs

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services