You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/07/07 03:22:23 UTC
[kudu-CR] [quorum util-test] scenario for node decommissioning
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10889
Change subject: [quorum_util-test] scenario for node decommissioning
......................................................................
[quorum_util-test] scenario for node decommissioning
Added an additional unit test and a scenario to ensure the current
implementation of the 3-4-3 replica management scheme handles
decommissioning of multiple tablet server (or nodes) as expected.
Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
---
M src/kudu/consensus/quorum_util-test.cc
1 file changed, 115 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/10889/1
--
To view, visit http://gerrit.cloudera.org:8080/10889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [quorum util-test] scenario for node decommissioning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10889 )
Change subject: [quorum_util-test] scenario for node decommissioning
......................................................................
Patch Set 2: Code-Review+2
Re-based, added more comments and fixed a typo in the commit message.
Carrying over Will's +2 from PS1.
--
To view, visit http://gerrit.cloudera.org:8080/10889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 20:12:31 +0000
Gerrit-HasComments: No
[kudu-CR] [quorum util-test] scenario for node decommissioning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10889
to look at the new patch set (#2).
Change subject: [quorum_util-test] scenario for node decommissioning
......................................................................
[quorum_util-test] scenario for node decommissioning
Added an additional unit test and a scenario to ensure the current
implementation of the 3-4-3 replica management scheme handles
decommissioning of multiple tablet servers (or nodes) as expected.
Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
---
M src/kudu/consensus/quorum_util-test.cc
1 file changed, 120 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/10889/2
--
To view, visit http://gerrit.cloudera.org:8080/10889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [quorum util-test] scenario for node decommissioning
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10889 )
Change subject: [quorum_util-test] scenario for node decommissioning
......................................................................
[quorum_util-test] scenario for node decommissioning
Added an additional unit test and a scenario to ensure the current
implementation of the 3-4-3 replica management scheme handles
decommissioning of multiple tablet servers (or nodes) as expected.
Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Reviewed-on: http://gerrit.cloudera.org:8080/10889
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/quorum_util-test.cc
1 file changed, 120 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [quorum util-test] scenario for node decommissioning
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10889 )
Change subject: [quorum_util-test] scenario for node decommissioning
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Thanks for adding this! It's good to know it will work nicely when we implement decommissioning.
http://gerrit.cloudera.org:8080/#/c/10889/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10889/1//COMMIT_MSG@11
PS1, Line 11: server
servers
--
To view, visit http://gerrit.cloudera.org:8080/10889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46e0946c474095095e9a8ccd84580e945dd4921b
Gerrit-Change-Number: 10889
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 11 Jul 2018 19:23:11 +0000
Gerrit-HasComments: Yes