You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "David Phillips (JIRA)" <ji...@apache.org> on 2008/12/15 21:47:44 UTC
[jira] Created: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Allow specifying custom input and output format in CREATE TABLE
---------------------------------------------------------------
Key: HIVE-177
URL: https://issues.apache.org/jira/browse/HIVE-177
Project: Hadoop Hive
Issue Type: Bug
Reporter: David Phillips
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated HIVE-177:
--------------------------------
Attachment: hive-create-fileformat.patch
Thanks for the review. Good comments; patch updated.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657874#action_12657874 ]
Ashish Thusoo commented on HIVE-177:
------------------------------------
Looks good to me.
There are a few minor comments:
1. I think instead of hardcoding the class name strings in the variables used to set the input and output formats for sequence and text files, we should instead use the Class.getName() function so that if we move those classes around later, we do not break these strings.
2. Can we make the run time error code better for the case where negative test case for voids.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Attachments: hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated HIVE-177:
--------------------------------
Status: Patch Available (was: Open)
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Attachments: hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659306#action_12659306 ]
David Phillips commented on HIVE-177:
-------------------------------------
Since this is already committed, I created HIVE-199 to address this.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Fix For: 0.2.0
>
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-177:
--------------------------------
Fix Version/s: 0.3.0
(was: 0.6.0)
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Fix For: 0.3.0
>
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated HIVE-177:
--------------------------------
Component/s: Query Processor
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-177:
----------------------------
Resolution: Fixed
Fix Version/s: 0.2.0
Release Note: HIVE-177. Allow specifying custom input and output format in CREATE TABLE. (David Phillips via zshao)
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed revision 729176. Thanks David!
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Fix For: 0.2.0
>
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659290#action_12659290 ]
Ashish Thusoo commented on HIVE-177:
------------------------------------
my bad. should have caught that in the review. The intent was surely to support writes as well.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Fix For: 0.2.0
>
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips reassigned HIVE-177:
-----------------------------------
Assignee: David Phillips
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-177) Allow specifying custom input and output
format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Phillips updated HIVE-177:
--------------------------------
Attachment: hive-create-fileformat.patch
The patch passes all tests.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Attachments: hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658721#action_12658721 ]
Ashish Thusoo commented on HIVE-177:
------------------------------------
+1
looks good to me.
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "David Phillips (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656746#action_12656746 ]
David Phillips commented on HIVE-177:
-------------------------------------
Proposed syntax:
{noformat}
CREATE TABLE ...
STORED AS file_format
file_format:
: SEQUENCEFILE
| TEXTFILE
| INTPUTFORMAT 'MyInputFormat' OUTPUTFORMAT 'MyOutputFormat'
{noformat}
Example:
{noformat}
CREATE TABLE ...
STORED AS
INPUTFORMAT 'org.apache.hadoop.mapred.TextInputFormat'
OUTPUTFORMAT 'org.apache.hadoop.hive.ql.io.IgnoreKeyTextOutputFormat'
{noformat}
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-177) Allow specifying custom input and
output format in CREATE TABLE
Posted by "Joydeep Sen Sarma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659176#action_12659176 ]
Joydeep Sen Sarma commented on HIVE-177:
----------------------------------------
BTW - this patch may allow reading of tables from arbitrary format - but it will not allow writing to tables of arbitrary outputformat. FileSinkOperator allows writing to sequencefile or textfile only.
perhaps the intent is to only read from other stuff - but the legal syntax is now allowing a capability that the execution engine does not support. (ie. - either we should not support outputformat other than text/sequencefile - or implement support for writing to other outputformats)
> Allow specifying custom input and output format in CREATE TABLE
> ---------------------------------------------------------------
>
> Key: HIVE-177
> URL: https://issues.apache.org/jira/browse/HIVE-177
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: David Phillips
> Assignee: David Phillips
> Fix For: 0.2.0
>
> Attachments: hive-create-fileformat.patch, hive-create-fileformat.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.