You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/04/17 07:13:03 UTC
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/527
STORM-790 Log "task is null" instead of let worker died when task is null in transfer-fn
When task is null in transfer-fn, creating TaskMessage leads NPE.
Please refer https://issues.apache.org/jira/browse/STORM-770 and https://issues.apache.org/jira/browse/STORM-790.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/527.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #527
----
commit 14477f4412f4adfaf42367e8a697e1a17b7dfb8e
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-04-17T05:09:39Z
Log "task is null" instead of let worker died
* when task is null in transfer-fn, creating TaskMessage leads NPE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-97610139
+1
@HeartSaVioR I'll ad this to the list of patches for 0.9.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-97400633
@ptgoetz I'd like to add this patch to 0.9.x since it verifies that it prevents strange worker crash cause of null task id. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-95369244
@revans2 I've updated PR to leave tuple type which can give us detailed evidence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-106824785
@HeartSaVioR This patch has been applied to 0.9.x and 0.10.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-94477300
@revans2 Yes, actually it's not easily reproductive, so I'd like to gather error log representing tuple information, encourage Stas Levin to apply it and report logs if found any.
Without applying this patch (or adding hook) we can't get informations about tuple making crash.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-95357185
https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14507221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14507221
Michael Pershyn applied current PR by hand and met that situation again, 6 machines, last 3 hours, 2 messages left.
Without patch it should be crashed.
Btw, we're succeed to gather information, see information
https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14507221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14507221
and my observation
https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14508036&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14508036
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by pershyn <gi...@git.apache.org>.
Github user pershyn commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-97111490
I have tested these changes on pure 0.9.3.
With them [STORM-770](https://issues.apache.org/jira/browse/STORM-770) doesn't break the affected bolts, rather prints warning messages:
```
2015-04-27T16:39:02.503+0200 b.s.d.worker [WARN] Can't transfer tuple - task value is nil. tuple type: nil and information: nil
```
I have also [commented](https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14517213&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14517213) STORM-770
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-104779949
+1 for merging this in. It does not apply to 0.9.x-branch though. If you want me to merge this to 0.10.x-branch and master I am happy to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/527
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-106741650
It seems to be merged to master well. Thanks for reviewing and merging!
Btw, it is an active bug, so IMO it should be applied to 0.9.5 and 0.10.0, too.
Did you intend to leave works for cherry-picking and releasing JIRA issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-94471958
@HeartSaVioR
Looking at the code prior to https://github.com/apache/storm/commit/861a92eab8740cfc0f83ac4d7ade9a2ab04a8b9b null routing was silently ignored. I'm not sure that was on purpose though. I am OK merging this in, but I really would like to understand why the destination task is showing up as null occasionally, but I see that you addressed that in the comments here https://issues.apache.org/jira/browse/STORM-770?focusedCommentId=14499225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14499225
So I am +1 for the change. At least now we explicitly handle the situation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-790 Log "task is null" instead of let wo...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/527#issuecomment-95593966
@HeartSaVioR great I am still +1 on the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---