[PATCH] mod_disk_cache early size-check

[Niklas Edmundsson <ni...@acc.umu.se>]

This patch takes advantage of the possibility to do the size-check of 
the file to be cached early.

The current behaviour is to start caching the file and then bail out 
when it notices that it has cached more than the maximum allowed size. 
The old checks still has to be there since the size might be unknown 
when create_entity() is called.

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  "=This= guy's beginning to crisp my cape..." - DarkWing Duck
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH] mod_disk_cache early size-check

[Brian Akins <br...@turner.com>]

Niklas Edmundsson wrote:
> 
> This patch takes advantage of the possibility to do the size-check of 
> the file to be cached early.
>      obj->vobj = dobj = apr_pcalloc(r->pool, sizeof(*dobj));


Shouldn't this be in mod_cache so that all providers do not have to 
duplicate this logic?

-- 
Brian Akins
Lead Systems Engineer
CNN Internet Technologies

Re: [PATCH] mod_disk_cache early size-check

[Ruediger Pluem <rp...@apache.org>]

On 05/30/2006 12:55 PM, Niklas Edmundsson wrote:
> 
> This patch takes advantage of the possibility to do the size-check of
> the file to be cached early.
> 
> The current behaviour is to start caching the file and then bail out
> when it notices that it has cached more than the maximum allowed size.
> The old checks still has to be there since the size might be unknown
> when create_entity() is called.

Thanks for the patch. Committed to trunk as r411469
(http://svn.apache.org/viewvc?rev=411469&view=rev).

Regards

Rüdiger