You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/20 11:29:22 UTC
[GitHub] [flink] zentol commented on a diff in pull request #19523: [FLINK-27287][tests] Use random ports
zentol commented on code in PR #19523:
URL: https://github.com/apache/flink/pull/19523#discussion_r854026236
##########
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/util/JobManagerWatermarkTrackerTest.java:
##########
@@ -18,57 +18,30 @@
package org.apache.flink.streaming.connectors.kinesis.util;
import org.apache.flink.configuration.Configuration;
-import org.apache.flink.configuration.RestOptions;
-import org.apache.flink.runtime.minicluster.MiniCluster;
-import org.apache.flink.runtime.minicluster.MiniClusterConfiguration;
+import org.apache.flink.runtime.testutils.MiniClusterResource;
+import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration;
import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
import org.apache.flink.streaming.api.functions.sink.SinkFunction;
import org.apache.flink.streaming.api.functions.source.RichSourceFunction;
-import org.junit.AfterClass;
import org.junit.Assert;
-import org.junit.BeforeClass;
+import org.junit.ClassRule;
import org.junit.Test;
/** Test for {@link JobManagerWatermarkTracker}. */
public class JobManagerWatermarkTrackerTest {
- private static MiniCluster flink;
-
- @BeforeClass
- public static void setUp() throws Exception {
- final Configuration config = new Configuration();
- config.setInteger(RestOptions.PORT, 0);
-
- final MiniClusterConfiguration miniClusterConfiguration =
- new MiniClusterConfiguration.Builder()
- .setConfiguration(config)
- .setNumTaskManagers(1)
- .setNumSlotsPerTaskManager(1)
- .build();
-
- flink = new MiniCluster(miniClusterConfiguration);
-
- flink.start();
- }
-
- @AfterClass
- public static void tearDown() throws Exception {
- if (flink != null) {
- flink.close();
- }
- }
+ @ClassRule
+ public static final MiniClusterResource FLINK =
+ new MiniClusterResource(
+ new MiniClusterResourceConfiguration.Builder()
Review Comment:
MiniClusterResource uses random ports by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org