You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Zhenhao Li (JIRA)" <ji...@apache.org> on 2018/03/21 14:30:00 UTC
[jira] [Updated] (YARN-8057) Inadequate information for handling
catch clauses
[ https://issues.apache.org/jira/browse/YARN-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhenhao Li updated YARN-8057:
-----------------------------
Description:
Their are some situations that different exception types are caught, but the handling of those exceptions can not show the differences of those types. Here are the code snippets we found which have this problem:
*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*
[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]
At Line *125* and Line *129.* We can see that two exception types are caught, but the logging statements here can not show the exception type at all. It may cause confusions to the person who is reading the log, the person can not know what exception happened here.
Maybe adding stack trace information to these two logging statements is a simple way to improve it.
was:
Their are some situations that different exception types are caught, but the handling of those exceptions can not show the differences of those types. Here are the code snippet we found which have this problem:
*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*
[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]
At Line *125* and Line *129.* We can see that two exception types are caught, but the logging statements here can not show the exception type at all. It may cause confusions to the person who are reading the log, the person can not know what exception happened here.
Maybe adding stack trace information to these two logging statements is a simple way to improve it.
> Inadequate information for handling catch clauses
> -------------------------------------------------
>
> Key: YARN-8057
> URL: https://issues.apache.org/jira/browse/YARN-8057
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: api, yarn
> Affects Versions: 3.0.0
> Reporter: Zhenhao Li
> Priority: Major
> Labels: easyfix
>
> Their are some situations that different exception types are caught, but the handling of those exceptions can not show the differences of those types. Here are the code snippets we found which have this problem:
> *org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*
> [https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]
> At Line *125* and Line *129.* We can see that two exception types are caught, but the logging statements here can not show the exception type at all. It may cause confusions to the person who is reading the log, the person can not know what exception happened here.
>
> Maybe adding stack trace information to these two logging statements is a simple way to improve it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org