[jira] [Commented] (AMQ-6672) Use a dynamic proxy in place of hand crafted read only objects for AMQP test client

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006798#comment-16006798 ] 

ASF subversion and git services commented on AMQ-6672:
------------------------------------------------------

Commit fddbac2b8a6b2686c0305e3e24a8ac549cc9e345 in activemq's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=fddbac2 ]

AMQ-6672 Use a dynamic proxy to create unmodifiable types

Use a dynamic proxy instead of hand-crafted wrappers around proton
types to prevent access to mutating methods in tests that could
inadvertantly change the state outside the connection thread.


> Use a dynamic proxy in place of hand crafted read only objects for AMQP test client 
> ------------------------------------------------------------------------------------
>
>                 Key: AMQ-6672
>                 URL: https://issues.apache.org/jira/browse/AMQ-6672
>             Project: ActiveMQ
>          Issue Type: Improvement
>          Components: AMQP
>    Affects Versions: 5.14.5
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>             Fix For: 5.15.0
>
>
> Currently the AMQP test client uses hand crafted read-only wrappers around certain Proton objects returned from the client code to prevent a test from accidentally changing proton state outside the connection object's handler thread.  This is a bit cumbersome as these classes tend to need minor tweaks each time the proton library is updated.  We can instead use a proxy for the proton types generated on the fly to protect most of the proton code from being modified and not need to make changes on each version update.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)