You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by as...@apache.org on 2024/01/09 22:29:56 UTC

(arrow) 01/05: MINOR: [R] Increase timeout for binary download (#39080)

This is an automated email from the ASF dual-hosted git repository.

assignuser pushed a commit to branch maint-14.0.2-cran
in repository https://gitbox.apache.org/repos/asf/arrow.git

commit 3c40da84e1e6c83e18afcd5f7b1bc7707b4a2028
Author: Jacob Wujciak-Jens <ja...@wujciak.de>
AuthorDate: Tue Dec 5 22:39:32 2023 +0100

    MINOR: [R] Increase timeout for binary download (#39080)
    
    ### Rationale for this change
    
    Download of mac binaries failed on CRAN and would likely fail on my local ancient bandwidth DSL (~300-500kbs) as well so a bit more buffer in the timeour value should help.
    
    ### What changes are included in this PR?
    
    Increase timeout.
    
    ### Are these changes tested?
    
    Not really testable.
    
    ### Are there any user-facing changes?
    
    No.
    
    Authored-by: Jacob Wujciak-Jens <ja...@wujciak.de>
    Signed-off-by: Jacob Wujciak-Jens <ja...@wujciak.de>
---
 r/tools/nixlibs.R | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/r/tools/nixlibs.R b/r/tools/nixlibs.R
index 161cea3abd..f4ae7312d3 100644
--- a/r/tools/nixlibs.R
+++ b/r/tools/nixlibs.R
@@ -81,8 +81,9 @@ find_latest_nightly <- function(description_version,
 try_download <- function(from_url, to_file, hush = quietly) {
   # We download some fairly large files, so ensure the timeout is set appropriately.
   # This assumes a static library size of 100 MB (generous) and a download speed
-  # of 1 MB/s (slow).
-  opts <- options(timeout = max(100, getOption("timeout")))
+  # of .3 MB/s (slow). This is to anticipate slower user connections or load on
+  # artifactory servers.
+  opts <- options(timeout = max(300, getOption("timeout")))
   on.exit(options(opts))
 
   status <- try(