You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/22 18:22:43 UTC
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/165
CB-10636 Add JSHint for plugins
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
Fixed file.spec.115
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-file CB-10636
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/165.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #165
----
commit fdb0734b29b132cbee86b123371e0328bdf474cd
Author: daserge <v-...@microsoft.com>
Date: 2016-02-22T16:14:26Z
CB-10636 Add JSHint for plugins
Fixed file.spec.115
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911524
--- Diff: tests/tests.js ---
@@ -18,9 +18,10 @@
*
*/
-/*global cordova, exports*/
-/*jshint jasmine: true*/
-/*global FileError, LocalFileSystem, Metadata, Flags*/
+/* global cordova, exports */
--- End diff --
Most of these globals already defined in `.jshintrc`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53918932
--- Diff: tests/tests.js ---
@@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {
expect(entries[0].toNativeURL).toBeDefined();
expect(typeof entries[0].toNativeURL).toBe('function');
var nativeURL = entries[0].toNativeURL();
- var indexOfRoot = isWindows ? nativeURL.indexOf(":") :
- isChrome ? 'filesystem:file://'.length : // Chrome uses own prefix for all filesystem urls
- 7; //default value - length of 'file://' string
expect(typeof nativeURL).toBe("string");
expect(nativeURL.substring(0, pathExpect.length)).toEqual(pathExpect);
expect(nativeURL.substring(nativeURL.length - fileName.length)).toEqual(fileName);
// cleanup
+ // TODO: debug this
--- End diff --
Thanks, this is addressed below, just forgot to rm the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#issuecomment-188155119
Mostly LGTM apart from a few minor comments/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53910671
--- Diff: src/firefoxos/FileProxy.js ---
@@ -67,10 +69,12 @@ QUIRKS:
exports.requestFileSystem = function(successCallback, errorCallback, args) {
var type = args[0];
- var size = args[1];
+ //var size = args[1];
--- End diff --
Please either remove commented lines, or add an additional message why this commented out but not removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53921776
--- Diff: tests/tests.js ---
@@ -18,9 +18,10 @@
*
*/
-/*global cordova, exports*/
-/*jshint jasmine: true*/
-/*global FileError, LocalFileSystem, Metadata, Flags*/
+/* global cordova, exports */
--- End diff --
Updated, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911243
--- Diff: www/blackberry10/write.js ---
@@ -40,7 +40,7 @@ module.exports = function (success, fail, args) {
var uri = args[0],
data = args[1],
offset = args[2],
- isBinary = args[3],
+ //isBinary = args[3],
--- End diff --
Same as in the first comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53911054
--- Diff: tests/tests.js ---
@@ -3040,20 +3045,19 @@ exports.defineAutoTests = function () {
expect(entries[0].toNativeURL).toBeDefined();
expect(typeof entries[0].toNativeURL).toBe('function');
var nativeURL = entries[0].toNativeURL();
- var indexOfRoot = isWindows ? nativeURL.indexOf(":") :
- isChrome ? 'filesystem:file://'.length : // Chrome uses own prefix for all filesystem urls
- 7; //default value - length of 'file://' string
expect(typeof nativeURL).toBe("string");
expect(nativeURL.substring(0, pathExpect.length)).toEqual(pathExpect);
expect(nativeURL.substring(nativeURL.length - fileName.length)).toEqual(fileName);
// cleanup
+ // TODO: debug this
--- End diff --
Please either address this TODO or remove this line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file pull request: CB-10636 Add JSHint for plugins
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/165#discussion_r53919580
--- Diff: src/firefoxos/FileProxy.js ---
@@ -67,10 +69,12 @@ QUIRKS:
exports.requestFileSystem = function(successCallback, errorCallback, args) {
var type = args[0];
- var size = args[1];
+ //var size = args[1];
--- End diff --
This var is not used, although it would be useful to leave it as a comment in terms of the function signature definition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org