You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2016/08/04 00:21:11 UTC
[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...
GitHub user zuyu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/79
Constructed Generators once in the optimizer.
Instead of creating generators each time per query, do so once, and reuse the instances for every query.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep refactor-optimizer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit 15d2cbd6d7f3814956bf92e264a34d7064d7dfc7
Author: Zuyu Zhang <zu...@twitter.com>
Date: 2016-08-04T00:19:07Z
Constructed Generators once in the optimizer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/79
That sounds good. Note that the refactoring needs quite some work to pass `optimizer_context` around, especially in `ExecutionGenerator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/79
@jianqiao I need your input on the correctness of this PR if we have concurrent queries running. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.
Posted by jianqiao <gi...@git.apache.org>.
Github user jianqiao commented on the issue:
https://github.com/apache/incubator-quickstep/pull/79
@zuyu The `Generator`'s can be stateless (need some refactoring), but each query should have its own `OptimizerContext`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #79: Constructed Generators once in the opt...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #79: Constructed Generators once in the optimizer.
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/79
@jianqiao Thank you for your comments.
What do you think if we move `OptimizerContext` from `Optimizer` to `QueryHandle`, which is unique per query?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---