You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/06/15 14:24:13 UTC

[GitHub] [accumulo] milleruntime commented on pull request #2160: Attempt to fix problems with cacheId

milleruntime commented on pull request #2160:
URL: https://github.com/apache/accumulo/pull/2160#issuecomment-861544072


   > I think I need to spend some time doing a deep dive looking into how this cacheId is used to know if the overall strategy here is correct.
   > 
   > I do like the check for nonnull and the API changes to the builder to require the cacheId when the InputStream is used, but have concerns about the value of using cacheIds that aren't predictable.
   
   OK how about I just simplify this change to add the nonnull check and include the cacheId (keeping the value the same). Then you can take it and explore further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org