You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "FlechazoW (via GitHub)" <gi...@apache.org> on 2023/01/30 08:31:47 UTC

[GitHub] [incubator-seatunnel] FlechazoW commented on a diff in pull request #3939: [Improve][Code-Style] Add the spotless plugin for unified code style.

FlechazoW commented on code in PR #3939:
URL: https://github.com/apache/incubator-seatunnel/pull/3939#discussion_r1090304869


##########
.github/workflows/backend.yml:
##########
@@ -302,14 +301,14 @@ jobs:
       - name: run all modules unit test
         if: needs.changes.outputs.api == 'true'
         run: |
-          ./mvnw -B -T 1C clean verify -D"maven.test.skip"=false -D"checkstyle.skip"=true -D"license.skipAddThirdParty"=true --no-snapshot-updates
+          ./mvnw -B -T 1C clean verify -D"maven.test.skip"=false -D"license.skipAddThirdParty"=true --no-snapshot-updates

Review Comment:
   I have removed the plugin of 'checkstyle', it will throw an error of 'can not find plugin of checkstyle' if we still keep the 'checkstyle.skip'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org