[jira] [Commented] (IMPALA-7356) Stress test for memory-based admission control

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-7356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16615032#comment-16615032 ] 

ASF subversion and git services commented on IMPALA-7356:
---------------------------------------------------------

Commit 7793124b6cb7d2e16e7389e59e33cec4963175ad in impala's branch refs/heads/master from [~tarmstrong@cloudera.com]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=7793124 ]

IMPALA-7487: fix stress test handling of AC memory rejection

The bug was introduced in IMPALA-7356 part 1, which started
classifying some memory errors as AC rejection errors. The
binary search has special handling of mem_limit_exceeded,
and ended up generating incorrect runtime info.

Fix the error classification by checking for the memory-related
error strings first, then rename mem_limit_exceeded to not_enough_memory
since it now encompasses a wide range of low memory conditions,
not just the "Memory limit exceeded" error.

I think the handling and classification of errors may need some
more thought, but this fix is sufficient to prevent the stress
test failures.

Testing:
Ran TPC-H stress test locally, which previous was reliably hitting the
error described in the JIRA.

Change-Id: Ia7526cc0bd49069712c1a1b13cbfb6453f6afa46
Reviewed-on: http://gerrit.cloudera.org:8080/11432
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: David Knupp <dk...@cloudera.com>


> Stress test for memory-based admission control
> ----------------------------------------------
>
>                 Key: IMPALA-7356
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7356
>             Project: IMPALA
>          Issue Type: Test
>          Components: Infrastructure
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>              Labels: admission-control
>
> We should extend the existing stress test to have a new mode designed to test memory-based admission control, where the stress test framework does not try to throttle memory consumption but instead relies on Impala doing so. 
> The required changes would be:
> * A mode to disable throttling
> * Options for stricter pass conditions - queries should not fail with OOM even if the stress test tries to submit way too many queries. 
> * However AC queue timeouts may be ok.
> * Investigation into the logic for choosing which query to run next and when - does that need to change?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org