You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/26 06:16:07 UTC

[GitHub] [flink] yuruguo opened a new pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

yuruguo opened a new pull request #14756:
URL: https://github.com/apache/flink/pull/14756


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   Update checkpoint_monitoring.zh.md
   
   
   ## Brief change log
   
     - Update docs/ops/monitoring/checkpoint_monitoring.zh.md
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on a change in pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #14756:
URL: https://github.com/apache/flink/pull/14756#discussion_r564274181



##########
File path: docs/ops/monitoring/checkpoint_monitoring.zh.md
##########
@@ -60,6 +60,8 @@ Flink 的 Web 界面提供了`选项卡/标签（tab）`来监视作业的 check
 
 Checkpoint 历史记录保存有关最近触发的 checkpoint 的统计信息，包括当前正在进行的 checkpoint。
 
+注意，对于失败的 checkpoint，指标会被尽最大努力进行更新并且可能不准确。

Review comment:
       ```suggestion
   注意，对于失败的 checkpoint，指标会尽最大努力进行更新，但是可能不准确。
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14756:
URL: https://github.com/apache/flink/pull/14756


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14756:
URL: https://github.com/apache/flink/pull/14756#issuecomment-767326796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08f7682c4217a85102b02cb4e54be30fa4f628eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on a change in pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
RocMarshal commented on a change in pull request #14756:
URL: https://github.com/apache/flink/pull/14756#discussion_r564274181



##########
File path: docs/ops/monitoring/checkpoint_monitoring.zh.md
##########
@@ -60,6 +60,8 @@ Flink 的 Web 界面提供了`选项卡/标签（tab）`来监视作业的 check
 
 Checkpoint 历史记录保存有关最近触发的 checkpoint 的统计信息，包括当前正在进行的 checkpoint。
 
+注意，对于失败的 checkpoint，指标会被尽最大努力进行更新并且可能不准确。

Review comment:
       ```suggestion
   注意，对于失败的 checkpoint，指标会尽最大努力进行更新，但是结果可能不准确。
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14756:
URL: https://github.com/apache/flink/pull/14756#issuecomment-767326796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12498",
       "triggerID" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08f7682c4217a85102b02cb4e54be30fa4f628eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12498) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14756:
URL: https://github.com/apache/flink/pull/14756#issuecomment-767322667


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6fead8508979f34822b89eec0e4d8eab2b2f75c9 (Fri May 28 08:06:47 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] yuruguo commented on a change in pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #14756:
URL: https://github.com/apache/flink/pull/14756#discussion_r564279419



##########
File path: docs/ops/monitoring/checkpoint_monitoring.zh.md
##########
@@ -60,6 +60,8 @@ Flink 的 Web 界面提供了`选项卡/标签（tab）`来监视作业的 check
 
 Checkpoint 历史记录保存有关最近触发的 checkpoint 的统计信息，包括当前正在进行的 checkpoint。
 
+注意，对于失败的 checkpoint，指标会被尽最大努力进行更新并且可能不准确。

Review comment:
       Nice, I think your translation is better. Can you @wuchong take a look？THX!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a change in pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14756:
URL: https://github.com/apache/flink/pull/14756#discussion_r564411603



##########
File path: docs/ops/monitoring/checkpoint_monitoring.zh.md
##########
@@ -60,6 +60,8 @@ Flink 的 Web 界面提供了`选项卡/标签（tab）`来监视作业的 check
 
 Checkpoint 历史记录保存有关最近触发的 checkpoint 的统计信息，包括当前正在进行的 checkpoint。
 
+注意，对于失败的 checkpoint，指标会被尽最大努力进行更新并且可能不准确。

Review comment:
       Yes. I think so.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14756:
URL: https://github.com/apache/flink/pull/14756#issuecomment-767322667


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 08f7682c4217a85102b02cb4e54be30fa4f628eb (Tue Jan 26 06:18:50 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14756: [FLINK-21122][docs] Update checkpoint_monitoring.zh.md

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14756:
URL: https://github.com/apache/flink/pull/14756#issuecomment-767326796


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12498",
       "triggerID" : "08f7682c4217a85102b02cb4e54be30fa4f628eb",
       "triggerType" : "PUSH"
     }, {
       "hash" : "6fead8508979f34822b89eec0e4d8eab2b2f75c9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6fead8508979f34822b89eec0e4d8eab2b2f75c9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08f7682c4217a85102b02cb4e54be30fa4f628eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12498) 
   * 6fead8508979f34822b89eec0e4d8eab2b2f75c9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org